Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: Save two redundant calls of GetLastError() #589

Open
wants to merge 1 commit into
base: Cog
Choose a base branch
from
Open

Windows: Save two redundant calls of GetLastError() #589

wants to merge 1 commit into from

Commits on Aug 30, 2021

  1. Save two redundant calls of GetLastError() 

    Assuming there was an eror during printing (wvsprintf) inside of vprintLastError(), the second call could have returned a different error code than expected.

Apart from that, to me it looks to be an idiom to call GetLastError() only once per error. In every case, printing errors now should be a tiny little bit faster. :-)
    @LinqLover
    LinqLover committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    8711574 View commit details
    Browse the repository at this point in the history