Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Save two redundant calls of GetLastError() #589

Open
wants to merge 1 commit into
base: Cog
Choose a base branch
from

Conversation

LinqLover
Copy link
Contributor

Assuming there was an error during printing (wvsprintf) inside of vprintLastError(), the second call could have returned a different error code than expected.

Apart from that, to me, it looks to be an idiom to call GetLastError() only once per error. In every case, printing errors now should be a tiny little bit faster. :-)

Assuming there was an eror during printing (wvsprintf) inside of vprintLastError(), the second call could have returned a different error code than expected.

Apart from that, to me it looks to be an idiom to call GetLastError() only once per error. In every case, printing errors now should be a tiny little bit faster. :-)
hogoww referenced this pull request in hogoww/opensmalltalk-vm Dec 25, 2021
hogoww referenced this pull request in hogoww/opensmalltalk-vm Dec 25, 2021
…false ] on method [ markAndShouldScan: ] KILLED by 1/10 test cases.
hogoww referenced this pull request in hogoww/opensmalltalk-vm Feb 26, 2022
…hod [ allOldSpaceEntitiesForCompactingFrom:to:do: ] 10 test cases.
hogoww referenced this pull request in hogoww/opensmalltalk-vm Feb 26, 2022
…od [ allOldSpaceEntitiesForCompactingFrom:to:do: ] 10/10 Test Cases are NOT EQUIVALENT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant