-
Notifications
You must be signed in to change notification settings - Fork 941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Titles to Functional Component Pages Only #7753
base: release/6.4.0
Are you sure you want to change the base?
Conversation
b785405
to
cfeb7d3
Compare
6eea9f1
to
f49b8c8
Compare
cf2f26c
to
e8d2599
Compare
Revert WIP conversion of Sectors test commit Fix paginationOptions issue for Groups, KillChainPhases, Roles Fix MarkingDefinitions, update KillChainPhases to reflect master Remove changes established in PR OpenCTI-Platform#7753 Add Malwares.tsx to removed changes Post-rebase cleanup
e8d2599
to
9a3956c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/6.4.0 #7753 +/- ##
=================================================
- Coverage 64.34% 64.32% -0.02%
=================================================
Files 608 608
Lines 58023 58023
Branches 6404 6401 -3
=================================================
- Hits 37332 37324 -8
- Misses 20691 20699 +8 ☔ View full report in Codecov by Sentry. |
af7523e
to
d51ab71
Compare
Revert WIP conversion of Sectors test commit Fix paginationOptions issue for Groups, KillChainPhases, Roles Fix MarkingDefinitions, update KillChainPhases to reflect master Remove changes established in PR OpenCTI-Platform#7753 Add Malwares.tsx to removed changes Post-rebase cleanup Remove changes from PR 7753
e71d6c3
to
a2c8237
Compare
Revert WIP conversion of Sectors test commit Fix paginationOptions issue for Groups, KillChainPhases, Roles Fix MarkingDefinitions, update KillChainPhases to reflect master Remove changes established in PR OpenCTI-Platform#7753 Add Malwares.tsx to removed changes Post-rebase cleanup Remove changes from PR 7753 Remove outdated changes to KillChainPhases Fix translations Align GroupLine design with master Fix typing on GroupLines;
This PR has a known issue. Every time a page renders, both the the custom page title setting function The following components from this PR are impacted:
|
732b9ce
to
aab7e1e
Compare
Revert WIP conversion of Sectors test commit Fix paginationOptions issue for Groups, KillChainPhases, Roles Fix MarkingDefinitions, update KillChainPhases to reflect master Remove changes established in PR OpenCTI-Platform#7753 Add Malwares.tsx to removed changes Post-rebase cleanup Remove changes from PR 7753 Remove outdated changes to KillChainPhases Fix translations Align GroupLine design with master Fix typing on GroupLines;
aab7e1e
to
ee40889
Compare
27900e0
to
3ad06e9
Compare
Revert WIP conversion of Sectors test commit Fix paginationOptions issue for Groups, KillChainPhases, Roles Fix MarkingDefinitions, update KillChainPhases to reflect master Remove changes established in PR OpenCTI-Platform#7753 Add Malwares.tsx to removed changes Post-rebase cleanup Remove changes from PR 7753 Remove outdated changes to KillChainPhases Fix translations Align GroupLine design with master Fix typing on GroupLines;
Revert WIP conversion of Sectors test commit Fix paginationOptions issue for Groups, KillChainPhases, Roles Fix MarkingDefinitions, update KillChainPhases to reflect master Remove changes established in PR OpenCTI-Platform#7753 Add Malwares.tsx to removed changes Post-rebase cleanup Remove changes from PR 7753 Remove outdated changes to KillChainPhases Fix translations Align GroupLine design with master Fix typing on GroupLines;
3ad06e9
to
3051e82
Compare
f8359b7
to
558e6c1
Compare
3051e82
to
e7e857e
Compare
Revert WIP conversion of Sectors test commit Fix paginationOptions issue for Groups, KillChainPhases, Roles Fix MarkingDefinitions, update KillChainPhases to reflect master Remove changes established in PR OpenCTI-Platform#7753 Add Malwares.tsx to removed changes Post-rebase cleanup Remove changes from PR 7753 Remove outdated changes to KillChainPhases Fix translations Align GroupLine design with master Fix typing on GroupLines;
Revert WIP conversion of Sectors test commit Fix paginationOptions issue for Groups, KillChainPhases, Roles Fix MarkingDefinitions, update KillChainPhases to reflect master Remove changes established in PR OpenCTI-Platform#7753 Add Malwares.tsx to removed changes Post-rebase cleanup Remove changes from PR 7753 Remove outdated changes to KillChainPhases Fix translations Align GroupLine design with master Fix typing on GroupLines;
e7e857e
to
29c4d52
Compare
Revert WIP conversion of Sectors test commit Fix paginationOptions issue for Groups, KillChainPhases, Roles Fix MarkingDefinitions, update KillChainPhases to reflect master Remove changes established in PR OpenCTI-Platform#7753 Add Malwares.tsx to removed changes Post-rebase cleanup Remove changes from PR 7753 Remove outdated changes to KillChainPhases Fix translations Align GroupLine design with master Fix typing on GroupLines; Remove variant from breadcrumbs
29c4d52
to
bee25ba
Compare
Revert WIP conversion of Sectors test commit Fix paginationOptions issue for Groups, KillChainPhases, Roles Fix MarkingDefinitions, update KillChainPhases to reflect master Remove changes established in PR OpenCTI-Platform#7753 Add Malwares.tsx to removed changes Post-rebase cleanup Remove changes from PR 7753 Remove outdated changes to KillChainPhases Fix translations Align GroupLine design with master Fix typing on GroupLines; Remove variant from breadcrumbs
bee25ba
to
312076a
Compare
Revert WIP conversion of Sectors test commit Fix paginationOptions issue for Groups, KillChainPhases, Roles Fix MarkingDefinitions, update KillChainPhases to reflect master Remove changes established in PR OpenCTI-Platform#7753 Add Malwares.tsx to removed changes Post-rebase cleanup Remove changes from PR 7753 Remove outdated changes to KillChainPhases Fix translations Align GroupLine design with master Fix typing on GroupLines; Remove variant from breadcrumbs
Revert WIP conversion of Sectors test commit Fix paginationOptions issue for Groups, KillChainPhases, Roles Fix MarkingDefinitions, update KillChainPhases to reflect master Remove changes established in PR OpenCTI-Platform#7753 Add Malwares.tsx to removed changes Post-rebase cleanup Remove changes from PR 7753 Remove outdated changes to KillChainPhases Fix translations Align GroupLine design with master Fix typing on GroupLines; Remove variant from breadcrumbs
eb71d68
to
88d15cb
Compare
Revert WIP conversion of Sectors test commit Fix paginationOptions issue for Groups, KillChainPhases, Roles Fix MarkingDefinitions, update KillChainPhases to reflect master Remove changes established in PR OpenCTI-Platform#7753 Add Malwares.tsx to removed changes Post-rebase cleanup Remove changes from PR 7753 Remove outdated changes to KillChainPhases Fix translations Align GroupLine design with master Fix typing on GroupLines; Remove variant from breadcrumbs
Revert WIP conversion of Sectors test commit Fix paginationOptions issue for Groups, KillChainPhases, Roles Fix MarkingDefinitions, update KillChainPhases to reflect master Remove changes established in PR OpenCTI-Platform#7753 Add Malwares.tsx to removed changes Post-rebase cleanup Remove changes from PR 7753 Remove outdated changes to KillChainPhases Fix translations Align GroupLine design with master Fix typing on GroupLines; Remove variant from breadcrumbs
Revert WIP conversion of Sectors test commit Fix paginationOptions issue for Groups, KillChainPhases, Roles Fix MarkingDefinitions, update KillChainPhases to reflect master Remove changes established in PR OpenCTI-Platform#7753 Add Malwares.tsx to removed changes Post-rebase cleanup Remove changes from PR 7753 Remove outdated changes to KillChainPhases Fix translations Align GroupLine design with master Fix typing on GroupLines; Remove variant from breadcrumbs
88d15cb
to
c928861
Compare
Revert WIP conversion of Sectors test commit Fix paginationOptions issue for Groups, KillChainPhases, Roles Fix MarkingDefinitions, update KillChainPhases to reflect master Remove changes established in PR OpenCTI-Platform#7753 Add Malwares.tsx to removed changes Post-rebase cleanup Remove changes from PR 7753 Remove outdated changes to KillChainPhases Fix translations Align GroupLine design with master Fix typing on GroupLines; Remove variant from breadcrumbs
c928861
to
d8e5a23
Compare
Revert WIP conversion of Sectors test commit Fix paginationOptions issue for Groups, KillChainPhases, Roles Fix MarkingDefinitions, update KillChainPhases to reflect master Remove changes established in PR OpenCTI-Platform#7753 Add Malwares.tsx to removed changes Post-rebase cleanup Remove changes from PR 7753 Remove outdated changes to KillChainPhases Fix translations Align GroupLine design with master Fix typing on GroupLines; Remove variant from breadcrumbs
WIP - Adding Titles to pages WIP - Updating Titles WIP - Updating Titles for Functional Components only. Updated Titles. Some class component pages have not been updated. Revert "Updated Titles. Some class component pages have not been updated." This reverts commit babb1cd. Updated Titles. Some class component pages have not been updated. Resolving Merge Conflicts [frontend] Replaced Creation Floating Action Buttons for Cases [frontend] Replaced Creation Floating Action Buttons for Observations Fixed minor errors Fixed duplicate issue. Add translations and linting Fix import issue from merge Minor cleanup Test commit Formatting change Add space to root again? Add settings pages that are already functional Add killChainPhases Update translations Add Narratives title Translate narratives Add data components Remove duplicate Data titles (pt 2) Add translations Fix case on Taxii.tsx Update translations
d8e5a23
to
94c4c47
Compare
Proposed changes
Related issues
Checklist
Further comments
The pages described in the Related Issues above have not been altered. Only functional component pages where the title persists have been updated. The other pages will be updated in a later PR once the issues have been identified and resolved.