[frontend] Add page titles to Data pages #8300
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerboseCat
force-pushed
the
convert_class_components_data
branch
from
fcf3ceb
to
9292742
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8300 +/- ##
==========================================
- Coverage 66.21% 66.20% -0.01%
==========================================
Files 597 597
Lines 60422 60422
Branches 6204 6201 -3
==========================================
- Hits 40008 40005 -3
- Misses 20414 20417 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
VerboseCat
force-pushed
the
convert_class_components_data
branch
from
02fc221
to
5350e04
Compare
SamuelHassine
force-pushed
the
master
branch
from
f8359b7
to
558e6c1
Compare
VerboseCat
force-pushed
the
convert_class_components_data
branch
2 times, most recently
from
51868e2
to
f1e9992
Compare
WIP - Adding Titles to pages WIP - Updating Titles WIP - Updating Titles for Functional Components only. Updated Titles. Some class component pages have not been updated. Revert "Updated Titles. Some class component pages have not been updated." This reverts commit babb1cd. Updated Titles. Some class component pages have not been updated. Resolving Merge Conflicts WIP - Converting class components to functional components WIP - pushing current updates. Fix merge issues Fix Roles.tsx to be able to compile Add latest version of Narratives.tsx Replace key 'FAB_REPLACED' with 'FAB_REPLACEMENT' Convert KillChainPhases to functional component Updated Sectors. Need to update SectorLine and SectorsLines. WIP - converting IngestionRss WIP - finished IngestionRSS conversion WIP WIP - Modified IngestionTaxiis WIP editing Connectors and Tasks. WIP - one more to convert WIP - modifying Streams.tsx and ImportContent.tsx. WIP Convert Connectors back to JSX functional component WIP - updated Streams Convert Stream to functional Finished Import Content Remove changes from PR 7753 Remove changes from PR 7753 (pt 2) Remove changes from PR 7753 (pt 3) Remove changes from PR 7753 (pt 4) Remove duplicate Data titles Remove duplicate Data titles (pt 3) Remove sectors.jsx Add translations Convert Sectors closer to original component Remove variant from breadcrumbs
VerboseCat
force-pushed
the
convert_class_components_data
branch
from
f1e9992
to
e966485
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR is a follow-up to the the PR which introduced custom page titles (#7374). This PR converts several 'Data' components from classes to functional and adds page titles. These components were not included in the original PR because they were class components and could not use the page title hook.
Impacted Pages
*
Related issues
Checklist
Further comments
This PR has a known issue, which has also been reported in a comment on (#7753). Every time a page renders, both the the custom page title setting function
useConnectedDocumentModifier.setTitleand the default page title setting functionuseDocumentLangModifierrun and set the title. In some instances, the default page title is set after the custom page title is set. This results in the default page title being displayed. I was unable to find a cause or pattern for which components exhibit this bug.The following components from this PR are impacted: