Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tactile_paving on crossing questions #194

Merged
merged 12 commits into from
Aug 9, 2023
Merged

Add tactile_paving on crossing questions #194

Changes from 7 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0a01e0d
Add tactile paving on crossings question
wielandb Jul 20, 2023
14ba28c
Add questions for rail and street crossings
wielandb Jul 20, 2023
3b2864b
Add question for `footway=crossing`
wielandb Jul 20, 2023
56fe09d
Correct condition for `footway=crossing`
wielandb Jul 20, 2023
1e7c82a
Dexomplexify question
wielandb Jul 28, 2023
ce41ee9
Remove (ALLE)
wielandb Jul 28, 2023
bcddb0e
crossing way is now allowed to have a crossing Node child
wielandb Jul 28, 2023
e203fbd
Collapse all crossing-tactile-paving-questions into one
wielandb Aug 3, 2023
fb8cce5
Remove footway=crossing from crossing question
wielandb Aug 4, 2023
b728245
Reword question
wielandb Aug 4, 2023
3b9279d
Combine conditions and add new image
7h30n3 Aug 9, 2023
0125073
Add image for rail crossing
7h30n3 Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
103 changes: 103 additions & 0 deletions assets/datasets/question_catalog.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2844,6 +2844,109 @@
}
]
},
{
"question": {
"name": "Übergang-Bodenindikatoren (Straßenbahn)",
"text": "Gibt es an beiden Seiten dieses Straßenbahn-Übergangs Bodenindikatoren?",
"description": "Bodenindikatoren dienen vor allem Sehbehinderten als Warnung vor abgesenkten Bordsteinen oder Straßenüberquerungen und verhindern so ein unbewusstes Betreten der Fahrbahn.",
"image": [
"assets/images/questions/tactile_paving_on_kerb.jpg"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Find an image for tactile paving on rails. I think @7h30n3 already has one.

]
},
"answer": {
"type": "Bool",
"input": [
{
"osm_tags": {
"tactile_paving": "yes"
}
},
{
"osm_tags": {
"tactile_paving": "no"
}
}
]
},
"conditions": [
{
"osm_tags": {
"railway": "tram_crossing",
"tactile_paving": false
},
"osm_element": "Node",
"parent": [
{
"!child": [
{
"osm_tags": {
"kerb": true
},
"osm_element": "Node"
}
]
}
]
}
]
},
{
"question": {
"name": "Übergangs-Bodenindikatoren",
"text": "Gibt es an beiden Enden dieses Übergangsweges Bodenindikatoren?",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the important key word at the start of the question, e.g.:
"Gibt es Bodenindikatoren an beiden Enden des Übergangs?"

"description": "Bodenindikatoren dienen vor allem Sehbehinderten als Warnung vor abgesenkten Bordsteinen oder Straßenüberquerungen und verhindern so ein unbewusstes Betreten der Fahrbahn.",
"image": [
"assets/images/questions/tactile_paving_on_kerb.jpg"
]
},
"answer": {
"type": "Bool",
"input": [
{
"osm_tags": {
"tactile_paving": "yes"
}
},
{
"osm_tags": {
"tactile_paving": "no"
}
}
]
},
"conditions": [
{
"osm_tags": {
"highway": "footway",
"footway": "crossing",
"tactile_paving": false
},
"osm_element": "OpenWay",
"!child": [
{
"osm_tags": {
"kerb": true
},
"osm_element": "Node"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is wrong.

]
},
{
"osm_tags": {
"highway": "crossing",
"tactile_paving": false
},
"osm_element": "Node"
},
{
"osm_tags": {
"railway": "crossing",
"tactile_paving": false
},
"osm_element": "Node"
}
]
},
{
"question": {
"name": "Verkehrsmittel",
Expand Down
Loading