Add tactile_paving on crossing questions
#194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Q: Is the current kerb tactile paving image sufficient? Or should a new photo be taken showing a crossing with tactile paving? |
wielandb
changed the title
tactile_paving on ``crossings question
wielandb
changed the title
tactile_paving on ``crossings questiontactile_paving on railway=tram_crossings question
wielandb
changed the title
tactile_paving on railway=tram_crossings questiontactile_paving on crossing questions
Not "child of a parent", rather only "child"
| "text": "Gibt es an beiden Seiten dieses Straßenbahn-Übergangs Bodenindikatoren?", | ||
| "description": "Bodenindikatoren dienen vor allem Sehbehinderten als Warnung vor abgesenkten Bordsteinen oder Straßenüberquerungen und verhindern so ein unbewusstes Betreten der Fahrbahn.", | ||
| "image": [ | ||
| "assets/images/questions/tactile_paving_on_kerb.jpg" |
There was a problem hiding this comment.
Find an image for tactile paving on rails. I think @7h30n3 already has one.
Comment on lines
2925
to
2938
| "!child": [ | ||
| { | ||
| "osm_tags": { | ||
| "kerb": true | ||
| }, | ||
| "osm_element": "Node" | ||
| }, | ||
| { | ||
| "osm_tags": { | ||
| "highway": "crossing" | ||
| }, | ||
| "osm_element": "Node" | ||
| } | ||
| ] |
7h30n3
reviewed
Jul 28, 2023
| { | ||
| "question": { | ||
| "name": "Übergangs-Bodenindikatoren", | ||
| "text": "Gibt es an beiden Enden dieses Übergangsweges Bodenindikatoren?", |
There was a problem hiding this comment.
Move the important key word at the start of the question, e.g.:
"Gibt es Bodenindikatoren an beiden Enden des Übergangs?"
7h30n3
reviewed
Aug 4, 2023
Comment on lines
2901
to
2906
| { | ||
| "osm_tags": { | ||
| "kerb": true | ||
| }, | ||
| "osm_element": "Node" | ||
| } |
|
The PR now asks the question in the following situations:
The question for |
yulieth9109
pushed a commit
to yulieth9109/OpenStop
that referenced
this pull request
Aug 31, 2023
--------- Co-authored-by: René Apitzsch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds questions that ask for tactile paving on
railway=tram_crossing,railway=crossingandhighway=crossing.I hope I understood the syntax for the conditions correctly.
My idea was: Ask the question only if for every parent element, there is no child element where
kerbis set.This should prevent the question from beeing asked on crossings where there are already kerbs mapped on the footway, where the question will be asked for the individual kerb elements.
Situations that theese questions are asked in:
railway=tram_crossing) has no tactile_paving, and the parent (way) has no children that are Nodes and have (kerb=*) (because if so, we should ask the question for the kerb-Nodes)highway=crossing) has no tactile_paving, and the parent (way) has no children that are Nodes and have (kerb=*) (because if so, we should ask the question for the kerb-Nodes)railway=crossing) has no tactile_paving, and the parent (way) has no children that are Nodes and have (kerb=*) (because if so, we should ask the question for the kerb-Nodes)footway=crossing) and has no tactile_paving, and it has no children that either havekerbortactile_pavingset.