Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "dae: 0.4.0 -> 0.5.0" #281740

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

pokon548
Copy link
Contributor

@pokon548 pokon548 commented Jan 18, 2024

Description of changes

According to upstream release page: https://github.com/daeuniverse/dae/releases/, the latest release is now reverted to v0.4.0.
Also, it has been reported that external dns resolver is broken on v0.5.0, which cause significant usability issue. See daeuniverse/dae#412.

I suggest that we should temporarily roll dae back to v0.4.0 before upstream publish new major release.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pokon548 pokon548 marked this pull request as ready for review January 18, 2024 10:00
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 18, 2024
@ofborg ofborg bot requested a review from oluceps January 18, 2024 10:32
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jan 18, 2024
@oluceps oluceps added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Jan 18, 2024
@NickCao NickCao merged commit d56fb44 into NixOS:master Jan 18, 2024
29 checks passed
@pokon548 pokon548 mentioned this pull request Jan 23, 2024
@pokon548 pokon548 mentioned this pull request Feb 8, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants