-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dae: 0.4.0 -> 0.6.0rc2 #287239
dae: 0.4.0 -> 0.6.0rc2 #287239
Conversation
6e0e35b
to
72d182c
Compare
Does this version function properly on your device? I've tested on mine and it fails to filter connections effectively. Everything works correctly on v0.4.0. |
Yes, I had deployed
Did you means the routing config will not works for you? If so, will try to reproduce on my vm (Seems also works fine for me). |
The manifestation is a connectivity check failure, as well as unsuccessful curl requests, it is unable to capture any connections from the host. Not only me find this issue. I'm trying to bisect commits. May need to add module options if there are changes that affect compatibility. FWIW the log of testing dae main HEAD: https://pb.nyaw.xyz/pleasing-crayfish.txt and my config file https://pb.nyaw.xyz/climbing-seahorse.txt. |
Reproduced with following config (Not minimal): https://fars.ee/o6Vp. smartdns config remains intact. |
My bad, seems the actual issue comes with this parameter:
If I set this option to |
This config caused the same issue on my machine when I set the option I'm not sure if this issue widely exists on |
Result of 1 package built:
|
Do we really need the rc version or can we use a release before that? |
Unfortunately no, as the last release |
Description of changes
As
0.4.0
is not compilable after kernel > 6.9, I have updateddae
to0.6.0rc2
and updated this pr. All descriptions down below is coming from the original0.5.1
pr.Due to the external dns issue: daeuniverse/dae#412, I had temporarily reverted
dae
to0.4.0
in #281740. Now this issue seems to be resolved on 0.5.1, tested usingsmartdns
as local resolver with following configs (sensitive info were redacted for privacy):config.dae:
smartdns:
Feel free to leave comments here if external dns works for you :)
By the way, I basically just changed
hash
andvendorHash
to adapt0.5.1
, based on the original0.5.0
commit from @zzzsyyy: #278695. It would not be possible for me to draft this pr so fast without that commit, so big thanks for your kind contribution!Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.