Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to LINDI tests #61

Merged
merged 6 commits into from
May 18, 2024
Merged

Improvements to LINDI tests #61

merged 6 commits into from
May 18, 2024

Conversation

CodyCBakerPhD
Copy link
Collaborator

Direct suggestions for #59

Also some results from one of my machines

@CodyCBakerPhD CodyCBakerPhD requested a review from rly May 18, 2024 16:21
@CodyCBakerPhD CodyCBakerPhD self-assigned this May 18, 2024
@rly
Copy link
Contributor

rly commented May 18, 2024

Nice! This looks great to me

@CodyCBakerPhD
Copy link
Collaborator Author

I have another follow-up fixing the params issue; turns out there is an in-built way of resolving it, not perfect but we don't have to change anything with our current setup

@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review May 18, 2024 23:13
@CodyCBakerPhD CodyCBakerPhD merged commit 6c4eaca into lindi_update May 18, 2024
2 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the improvements branch May 18, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants