Issue/318- Adding Video recording functionality to vispy viewer #334
Conversation
…by adding a new function record_video
…the 3D cell morphology
There was a problem hiding this comment.
Looking good, but needs a few changes. My main question is---can the canvas etc. we already create not be used? Why is a new one required?
Also: in the future, I wouldn't use the development branch for PRs. It's best to create a new branch from development and use that. That way your development branch always remains clean and matches our upstream development branch.
| view = scene_canvas.central_widget.add_view() | ||
|
|
||
| camera = scene_canvas.central_widget.camera | ||
| view.camera = camera | ||
|
|
||
| canvas = scene.SceneCanvas( |
There was a problem hiding this comment.
we're already creating a SceneCanvas, camera, view etc. here---do you need to create one too? Can the ones we already create not be used?
There was a problem hiding this comment.
yes sir you are correct I think I ignored this.
| if event.key == "r": | ||
| # Start recording video | ||
| output_file = "output.mp4" | ||
| duration = 10 # Video duration in seconds |
There was a problem hiding this comment.
Is there a way to not limit the video duration? We can have an upper limit, but ideally what we want is:
- press
rto start recording - press
rafter some time to stop recording
That'll allow users to make multiple recordings, and the file name can increment: output-1.mp4, output-2.mp4 and so on?
| @@ -120,6 +125,14 @@ def create_new_vispy_canvas( | |||
| """ | |||
| # vispy: full gl+ context is required for instanced rendering | |||
| use(gl="gl+") | |||
| canvas_name = "My 3D Visualization" | |||
| canvas, scene_canvas, view = create_new_vispy_canvas(canvas_name) | |||
There was a problem hiding this comment.
Isn't this calling itself recursively: create_new_vispy_canvas is calling itself, and there's no break clause to break the recursion? Have you tested this code out to see that it works?
sanjayankur31
added
T: enhancement
|
Repalced this with #342 to remove branch conflicts |
I have modified the code in the create_new_vispy_canvas function to add video recording functionality