Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nml.py): add level 2 validation for SegmentGroup #156

Draft
wants to merge 16 commits into
base: development
Choose a base branch
from
Draft

feat(nml.py): add level 2 validation for SegmentGroup #156

wants to merge 16 commits into from

Commits on Dec 2, 2022

  1. feat(nml.py): add level 2 validation for SegmentGroup 

    This also sets up a general framework for us to add more tests in
libNeuroML.
    @sanjayankur31
    sanjayankur31 committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    aaddfa8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'development' into feat/add-l2-validation-segmentgroup

    @sanjayankur31
    sanjayankur31 committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    616be3d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'development' into feat/add-l2-validation-segmentgroup

    @sanjayankur31
    sanjayankur31 committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    089da1b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'development' into feat/add-l2-validation-segmentgroup

    @sanjayankur31
    sanjayankur31 committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    4e3bbb3 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2023

  1. Merge branch 'development' into feat/add-l2-validation-segmentgroup

    @sanjayankur31
    sanjayankur31 committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    7415950 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2023

  1. feat(l2testing): add framework for level 2 validation tests

    @sanjayankur31
    sanjayankur31 committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    8b2eaa0 View commit details
    Browse the repository at this point in the history

  2. test(l2validators): add initial set of tests

    @sanjayankur31
    sanjayankur31 committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    87c2461 View commit details
    Browse the repository at this point in the history

  3. feat(l2validator): remove duplicate SegmentGroup validation test

    @sanjayankur31
    sanjayankur31 committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    c9feacb View commit details
    Browse the repository at this point in the history

  4. feat(l2validator): allow validation of objects by arbitrary test classes 

    This is so that an object of class A may also be tested with tests
defined for its ancestors. It is the developer's responsibility to
ensure that only the right tests are run for a particular object.

With great power, comes great responsibility!
    @sanjayankur31
    sanjayankur31 committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    f42bdeb View commit details
    Browse the repository at this point in the history

  5. test(l2validator): add test for segment group including itself

    @sanjayankur31
    sanjayankur31 committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    9260309 View commit details
    Browse the repository at this point in the history

  6. fix(l2validator): pass tests that are marked as warnings

    @sanjayankur31
    sanjayankur31 committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    46893e3 View commit details
    Browse the repository at this point in the history

  7. feat(generatedssuper): print out remaining collected messsages 

    When a validation test fails, we error immediately and print out the
validation error. However, if a test that's marked for warnings, not
errors fails, we don't error immediately, but we do print out the
collected warnings.
    @sanjayankur31
    sanjayankur31 committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    e5088fd View commit details
    Browse the repository at this point in the history

  8. chore(cell-helper): add todo to deduplicate based on contents also

    @sanjayankur31
    sanjayankur31 committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    b19c94d View commit details
    Browse the repository at this point in the history

  9. test(l2validator): add more tests

    @sanjayankur31
    sanjayankur31 committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    14c4554 View commit details
    Browse the repository at this point in the history

  10. fix(test-cell-optimise): correctly add duplicates of same object 

    The test was wrong, but not sure why it passed before. Each new Include
object is completely different, and would not count as a duplicate.

TODO: check this again and pin down why behaviour changed after addition
of l2validator test
    @sanjayankur31
    sanjayankur31 committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    cd28d71 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2023

  1. WIP: performance drops need investigation

    @sanjayankur31
    sanjayankur31 committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    518f294 View commit details
    Browse the repository at this point in the history