Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nml.py): add level 2 validation for SegmentGroup #156

Draft
wants to merge 16 commits into
base: development
Choose a base branch
from

Conversation

sanjayankur31
Copy link
Contributor

This also sets up a general framework for us to add more tests in libNeuroML.

This also sets up a general framework for us to add more tests in
libNeuroML.
@sanjayankur31 sanjayankur31 added the T: enhancement Type: enhancement label Dec 2, 2022
@sanjayankur31 sanjayankur31 self-assigned this Dec 2, 2022
@sanjayankur31
Copy link
Contributor Author

To make these self-contained and not dependent on nml.py, we want to:

  • split them out into a new module
  • use a consistent class framework so that these can be called from anywhere
  • let generateds import this module and use it in nml.py

@sanjayankur31 sanjayankur31 added the S: waiting for reporter Waiting for reporter to respond label Dec 5, 2022
This is so that an object of class A may also be tested with tests
defined for its ancestors. It is the developer's responsibility to
ensure that only the right tests are run for a particular object.

With great power, comes great responsibility!
When a validation test fails, we error immediately and print out the
validation error. However, if a test that's marked for warnings, not
errors fails, we don't error immediately, but we do print out the
collected warnings.
The test was wrong, but not sure why it passed before. Each new Include
object is completely different, and would not count as a duplicate.

TODO: check this again and pin down why behaviour changed after addition
of l2validator test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: waiting for reporter Waiting for reporter to respond T: enhancement Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant