Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1535 Add "Definitions of ZAP Updates" page to ZAP Search #1537

Merged
merged 7 commits into from
Oct 21, 2024

Conversation

dhochbaum-dcp
Copy link
Collaborator

@dhochbaum-dcp dhochbaum-dcp commented Sep 23, 2024

Add new "Definition of ZAP Updates" page to ZAP Search.

Acceptance Criteria:

  • New page should match designs in Figma
  • New page should be at route /statuses
  • Link in "To sign up for ZAP updates, please visit here" should link to /subscribe (not implemented)
  • Page should only be reachable if SHOW_ALERTS feature flag is true.

Out of scope

  • Adding "Email Notifications" button to banner at top of the site

@TylerMatteo to follow up with @jessicashanshanhuang about mobile designs

Note: The "subscribe" link is in the code, but since the route does not yet exist, the word linking to it is not displaying.

Completes #1535

Copy link

netlify bot commented Sep 23, 2024

Deploy Preview for labs-zap ready!

Name Link
🔨 Latest commit 071eaa9
🔍 Latest deploy log https://app.netlify.com/sites/labs-zap/deploys/6712bb899769830008f34637
😎 Deploy Preview https://deploy-preview-1537--labs-zap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dhochbaum-dcp dhochbaum-dcp changed the title Added status page 1535 Add "Definitions of ZAP Updates" page to ZAP Search Sep 23, 2024
@dhochbaum-dcp
Copy link
Collaborator Author

@jessicashanshanhuang the statuses page can now be previewed at https://deploy-preview-1537--labs-zap.netlify.app/statuses

Please take a look and let me know if there are any changes you would like me to make.

@dhochbaum-dcp dhochbaum-dcp force-pushed the 1535/Add-Definitions-of-ZAP-Updates-page branch from 57a8387 to 6f2e76f Compare September 30, 2024 18:12
@dhochbaum-dcp dhochbaum-dcp marked this pull request as ready for review September 30, 2024 18:54
@dhochbaum-dcp dhochbaum-dcp requested a review from a team as a code owner September 30, 2024 18:54
client/app/router.js Outdated Show resolved Hide resolved
@dhochbaum-dcp dhochbaum-dcp merged commit d462d6a into develop Oct 21, 2024
5 checks passed
@dhochbaum-dcp dhochbaum-dcp deleted the 1535/Add-Definitions-of-ZAP-Updates-page branch October 21, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants