-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1249 Submit project details for new project #1292
Draft
horatiorosa
wants to merge
9
commits into
main
Choose a base branch
from
1249-submit-project-details-for-new-project
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horatiorosa
requested review from
TangoYankee
and removed request for
TangoYankee
October 19, 2024 02:29
horatiorosa
force-pushed
the
1249-submit-project-details-for-new-project
branch
from
October 21, 2024 17:57
30b9aa4
to
64a0692
Compare
- refactored projects-new-information.hbs - extracted all contact form fields into a new template: projects-new-add-contacts.hbs - added boroughs to projects-new-information template using ember powerselect - added functions to projects/new..js to handle dropdown actions - updated project optionset to include boroughs and imported into optionsets.js
tried to make validations work, it was an incomplete success.
horatiorosa
force-pushed
the
1249-submit-project-details-for-new-project
branch
2 times, most recently
from
October 29, 2024 02:01
fbf722f
to
a904db9
Compare
horatiorosa
force-pushed
the
1249-submit-project-details-for-new-project
branch
2 times, most recently
from
October 29, 2024 16:12
284448b
to
a2a9c82
Compare
horatiorosa
force-pushed
the
1249-submit-project-details-for-new-project
branch
from
October 29, 2024 16:19
a2a9c82
to
289fc5e
Compare
horatiorosa
force-pushed
the
1249-submit-project-details-for-new-project
branch
from
November 6, 2024 14:54
ea6ead0
to
7fe467c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
projects-new-information.hbs
projects-new-add-contacts.hbs
projects-new-information
template using ember powerselectprojects/new.js
to handle dropdown actionsproject.js
optionset to include boroughs and imported intooptionsets.js
Tasks/Bug Numbers