-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make aerosol output frequency variable #2982
base: develop
Are you sure you want to change the base?
Make aerosol output frequency variable #2982
Conversation
The `AERO_HISTORY.rc` file that controls the GOCART output is turned into a template usint `@[ ]` syntax to allow for variable output times. A new "parsing" script is created for GOCART that handles parsing the `AERO_HISTORY.rc` file through `atparse`. Other manip- ulation of these files is also moved to the new parsing script to be consistent with other components. A new variable, `FHOUT_AERO` is introduced to control the output frequency of the GOCART output. This is initially set to 3 to match other components (this is a change from the current value of 6). Since some aerosol fields are also included as part of the atmos output, it may be desirable to meld this back into `FHOUT` later. However, the atmos output has two frequencies (`FHOUT_HF` and `FHOUT`), a feature not supported by other components. The RUN lists for aero fcst, aero analysis, and waves is simplified to avoid confusion, since there is no need for them to only be set if the components are on. Resolves NOAA-EMC#2072
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't test but this looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Question:
Not for this PR to address -- how diffferent is the parm/ufs/gocart/AERO_HISTORY.rc
file in the global-workflow from the one in ufs-weather-model?
@aerorahul Looks like they have already templated the one frequency we use, but not the others. A couple other small changes (also whitespace changes not shown):
(This is against our develop, not the changes in this PR.) |
Description
The
AERO_HISTORY.rc
file that controls the GOCART output is turned into a template usint@[ ]
syntax to allow for variable output times. A new "parsing" script is created for GOCART that handles parsing theAERO_HISTORY.rc
file throughatparse
. Other manip- ulation of these files is also moved to the new parsing script to be consistent with other components.A new variable,
FHOUT_AERO
is introduced to control the output frequency of the GOCART output. This is initially set to 3 to match other components (this is a change from the current value of 6). Since some aerosol fields are also included as part of the atmos output, it may be desirable to meld this back intoFHOUT
later. However, the atmos output has two frequencies (FHOUT_HF
andFHOUT
), a feature not supported by other components.The RUN lists for aero fcst, aero analysis, and waves is simplified to avoid confusion, since there is no need for them to only be set if the components are on.
Resolves #2072
Type of change
Change characteristics
How has this been tested?
AERO_FCST_RUN
)Checklist