Update FB_OUTPUT_DIMMER_MQTT.md #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichielVanwelsenaere
merged commit 35c6166
into
MichielVanwelsenaere:master
1 check failed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
To resolve issue #150 in the
FB_OUTPUT_DIMMER_MQTT.PublishReceivedfile line 15 and 29 needs to be changed fromTHIS^.OUT_Target:=STRING_TO_BYTE(Data.PayloadString^);toTHIS^.OUT_Internal:=STRING_TO_BYTE(Data.PayloadString^);.As requested by @MichielVanwelsenaere I've also added an exported FB_OUTPUT_DIMMER_MQTT that only holds the analog (0/1-10V) dimmer code (i.e. remove the DMX related code).
FB_OUTPUT_DIMMER_MQTT_ANALOG.export.zip
Related issues