Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimmer MQTT not updating values via MQTT (II) #156

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

markfra
Copy link
Contributor

@markfra markfra commented Mar 19, 2024

It seems that #151 failed due to deadlinks on the codesys website, so this is another try.

Also the proposed fix from #150 is not present in current master, as i still see THIS^.OUT_Target:=STRING_TO_BYTE(Data.PayloadString^); in stead of THIS^.OUT_Internal.

Do you need an export for that?

Pull Request Checklist

Check if the tasks below are relevant for your PR, to mark an item as completed use [X].

  • [/] I followed the CONTRIBUTING.md
  • Updated the PLCOpen XML export file (only relevant on code change).
  • Updated the CoDeSys V3 export file (only relevant on code change).
  • Updated or created any relevant documentation.

Proposed Changes

Related issues

@MichielVanwelsenaere
Copy link
Owner

Hi Mark

I'm aware the fix is not yet in master, I've created #155 for it though.
For the last weeks/months I've been lacking the time to encorperate the change.

I've however managed to implement heating and DALI on my personal setup. When I have some time I'll push allot of new stuff :)

@MichielVanwelsenaere MichielVanwelsenaere merged commit 5a964c5 into MichielVanwelsenaere:master Mar 21, 2024
1 check failed
@MichielVanwelsenaere MichielVanwelsenaere added the documentation Improvements or additions to documentation label Mar 21, 2024
@MichielVanwelsenaere MichielVanwelsenaere self-assigned this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants