-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: network menu snaphots #27311
test: network menu snaphots #27311
Conversation
…com:MetaMask/metamask-extension into brian/network-controller-v20-merging-in-v21
Co-authored-by: Maarten Zuidhoorn <[email protected]>
… brian/network-controller-v20-merging-in-v21
…com:MetaMask/metamask-extension into brian/network-controller-v20-merging-in-v21
… brian/network-controller-v20-merging-in-v21
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Quality Gate passedIssues Measures |
Builds ready [b7e57b8]
Page Load Metrics (1870 ± 144 ms)
Bundle size diffs
|
Missing release label release-12.5.0 on PR. Adding release label release-12.5.0 on PR and removing other release labels(release-12.6.0), as PR was added to branch 12.5.0 when release was cut. |
Description
Adds additional snapshots unit tests for the network form. And fixes the existing one. It was only snapshotting an empty
<div />
. Because of how modals work, you have to snapshotbaseElement
instead ofcontainer
.Related issues
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist