Skip to content

Commit

Permalink
test: network menu snaphots (#27311)
Browse files Browse the repository at this point in the history
## **Description**

Adds additional snapshots unit tests for the network form. And fixes the
existing one. It was only snapshotting an empty `<div />`. Because of
how modals work, you have to snapshot `baseElement` instead of
`container`.


[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27311?quickstart=1)

## **Related issues**



## **Manual testing steps**



## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: salimtb <[email protected]>
Co-authored-by: MetaMask Bot <[email protected]>
Co-authored-by: David Walsh <[email protected]>
Co-authored-by: Howard Braham <[email protected]>
Co-authored-by: Maarten Zuidhoorn <[email protected]>
  • Loading branch information
6 people authored Sep 20, 2024
1 parent 2550abc commit f73aa77
Show file tree
Hide file tree
Showing 2 changed files with 1,211 additions and 4 deletions.
Loading

0 comments on commit f73aa77

Please sign in to comment.