Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update notifications events (#26807) #26924

Merged
merged 2 commits into from
Sep 4, 2024
Merged

fix: update notifications events (#26807) #26924

merged 2 commits into from
Sep 4, 2024

Commits on Sep 4, 2024

  1. fix: update notifications events (#26807) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

This PR updates or corrects the events related to notifications. The
events have also been updated in the Segment repository.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26807?quickstart=1)

Fixes:

To test these new events, you can follow the standard procedure outlined
in the README file.

N/A

N/A

N/A

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @matteoscurati
    matteoscurati committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    fce3436 View commit details
    Browse the repository at this point in the history

  2. fix: 🐛 remove unused dependency

    @matteoscurati
    matteoscurati committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    2a74b2c View commit details
    Browse the repository at this point in the history