Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update notifications events (#26807) #26924

Conversation

matteoscurati
Copy link
Contributor

@matteoscurati matteoscurati commented Sep 4, 2024

This PR updates or corrects the events related to notifications. The events have also been updated in the Segment repository.

Open in GitHub Codespaces

Fixes:

To test these new events, you can follow the standard procedure outlined in the README file.

N/A

N/A

N/A

  • I've followed MetaMask Contributor Docs and MetaMask Extension Coding
    Standards
    .

  • I've completed the PR template to the best of my ability

  • I’ve included tests if applicable

  • I’ve documented my code using JSDoc format if applicable

  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).

  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

This PR updates or corrects the events related to notifications. The
events have also been updated in the Segment repository.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26807?quickstart=1)

Fixes:

To test these new events, you can follow the standard procedure outlined
in the README file.

N/A

N/A

N/A

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@matteoscurati matteoscurati added the team-notifications Notifications team label Sep 4, 2024
@matteoscurati matteoscurati marked this pull request as ready for review September 4, 2024 20:26
@matteoscurati matteoscurati requested review from a team as code owners September 4, 2024 20:26
Copy link
Contributor

github-actions bot commented Sep 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [2a74b2c]
Page Load Metrics (1535 ± 46 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint21117931475305147
domContentLoaded1400173615159144
load1408178215359546
domInteractive158830189

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 84.74576% with 9 lines in your changes missing coverage. Please review.

Project coverage is 70.49%. Comparing base (947095c) to head (2a74b2c).
Report is 1 commits behind head on Version-v12.2.0.

Files with missing lines Patch % Lines
...il-network-fee/notification-detail-network-fee.tsx 0.00% 3 Missing ⚠️
...il-copy-button/notification-detail-copy-button.tsx 77.78% 2 Missing ⚠️
...s/metamask-notifications/metamask-notifications.ts 85.71% 2 Missing ⚠️
...i/components/multichain/global-menu/global-menu.js 66.67% 1 Missing ⚠️
...ications-tag-counter/notifications-tag-counter.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           Version-v12.2.0   #26924      +/-   ##
===================================================
+ Coverage            70.48%   70.49%   +0.01%     
===================================================
  Files                 1400     1400              
  Lines                49577    49613      +36     
  Branches             13637    13649      +12     
===================================================
+ Hits                 34941    34971      +30     
- Misses               14636    14642       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danjm danjm merged commit 2c93db9 into Version-v12.2.0 Sep 4, 2024
64 checks passed
@danjm danjm deleted the v12.2.0/cherry-pick-44cf6ace9a3446487151d573b113dc29548534e7 branch September 4, 2024 23:37
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-notifications Notifications team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants