Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: flaky test vault-decrypt by removing driver navigate to open a new window #25443

Merged
merged 3 commits into from
Jun 21, 2024
Merged

fix: flaky test vault-decrypt by removing driver navigate to open a new window #25443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4eb2710
remove navigate step
seaona Jun 20, 2024
114c11c
fix lavamoat error
seaona Jun 21, 2024
265d1e3
add back filter
seaona Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions development/build/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ async function defineAndRunBuildTasks() {

let scuttleGlobalThisExceptions = [
// globals used by different mm deps outside of lm compartment
'Proxy',
'toString',
'getComputedStyle',
'addEventListener',
Expand Down
6 changes: 3 additions & 3 deletions test/e2e/vault-decryption-chrome.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,9 @@ async function getSRP(driver) {
describe('Vault Decryptor Page', function () {
it('is able to decrypt the vault using the vault-decryptor webapp', async function () {
await withFixtures({}, async ({ driver }) => {
await driver.navigate();
// the first app launch opens a new tab, we need to switch the focus
// to the first one.
// we don't need to use navigate
// since MM will automatically open a new window in prod build
await driver.waitUntilXWindowHandles(2);
await driver.switchToWindowWithTitle('MetaMask');
// create a new vault through onboarding flow
await completeCreateNewWalletOnboardingFlowWithOptOut(
Expand Down