fix: flaky test vault-decrypt by removing driver navigate to open a new window

[seaona]

Description

The vault decryption test opens 2 MetaMask windows whenever we start the test, causing flakiness in which window is currently selected and where the actions are performed.

Having 2 MM windows, together with the fact that the Chrome active window can sometimes not be the same as the Webdriver active window (see @HowardBraham 's work on that area), causes unpredictable effects - see video below.

For fixing it, we now remove the step of driver.navigate which will open a MM window, and caused to have 2 windows instead of 1.

However, this lead to a new problem. Lavamoat presents a race condition, which now is more present making the test fail in almost all runs. From @naugtur :

It is indeed a race condition, because scuttling can only destroy the global references after they've been successfully copied and used for establishing the root compartment of the application.

For fixing this, we add Proxy in the exceptions, following Lavamoat's team suggestion as a temporary solution.

mm-vault-decrypt-error.mp4

Related issues

Fixes:

Manual testing steps

See successful run here

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[weizman]

Lgtm

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.39%. Comparing base (2115516) to head (265d1e3).
Report is 22 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #25443   +/-   ##
========================================
  Coverage    65.39%   65.39%           
========================================
  Files         1382     1382           
  Lines        54764    54764           
  Branches     14369    14369           
========================================
  Hits         35809    35809           
  Misses       18955    18955           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [265d1e3]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (49 ± 3 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	64	92	78	7	3
		domContentLoaded	9	13	10	1	0
		load	40	67	49	7	3
		domInteractive	9	13	10	1	0

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[Gudahtt]

LGTM!

[naugtur]

Proxy exception is harmless.