Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Simplify Jest config and expand coverage #25013

Merged
merged 3 commits into from
Jun 24, 2024
Merged

test: Simplify Jest config and expand coverage #25013

merged 3 commits into from
Jun 24, 2024

Commits on Jun 24, 2024

  1. test: Fix test config 

    Our Mocha and Jest configuration has been messy because we're in the
middle of a migration from Mocha to Jest. Each file had to be
explicitly included in the Jest configuration or ignored in the Mocha
configuration. This was inconvenient and error-prone, and resulted in
some tests not being run at all.

Both test configurations have been updated to use a shared list of
Mocha test files. There are only a few of these files left, and this
list should only get shorter as we migrate more tests to Jest. No
further configuration changes will be needed to add Jest tests.
    @Gudahtt
    Gudahtt committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    5140ac2 View commit details
    Browse the repository at this point in the history

  2. Remove changes to how Mocha is run (we don't have any Mocha tests left)

    @Gudahtt
    Gudahtt committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    8fc7d82 View commit details
    Browse the repository at this point in the history

  3. Undo changes to Mocha config

    @Gudahtt
    Gudahtt committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    dda8b8c View commit details
    Browse the repository at this point in the history