test: Simplify Jest config and expand coverage #25013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
7 tasks
Gudahtt
force-pushed
the
fix-test-config
branch
4 times, most recently
from
443d685
to
0c04e01
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Gudahtt
force-pushed
the
fix-test-config
branch
2 times, most recently
from
d6bc055
to
f9029b7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25013 +/- ##
===========================================
- Coverage 70.44% 69.62% -0.83%
===========================================
Files 1274 1344 +70
Lines 44080 47795 +3715
Branches 12453 13190 +737
===========================================
+ Hits 31051 33273 +2222
- Misses 13029 14522 +1493 ☔ View full report in Codecov by Sentry. |
Builds ready [6d47993]
Page Load Metrics (165 ± 224 ms)
Bundle size diffs
|
Gudahtt
force-pushed
the
fix-test-config
branch
2 times, most recently
from
7ac6963
to
5c1b2f5
Compare
Builds ready [5c1b2f5]
Page Load Metrics (124 ± 148 ms)
Bundle size diffs
|
Gudahtt
added
the
needs-dev-review
|
Rebased to resolve conflicts, and the Mocha test coverage list has been removed because it was now empty. |
Builds ready [154d349]
Page Load Metrics (49 ± 3 ms)
Bundle size diffs
|
Our Mocha and Jest configuration has been messy because we're in the middle of a migration from Mocha to Jest. Each file had to be explicitly included in the Jest configuration or ignored in the Mocha configuration. This was inconvenient and error-prone, and resulted in some tests not being run at all. Both test configurations have been updated to use a shared list of Mocha test files. There are only a few of these files left, and this list should only get shorter as we migrate more tests to Jest. No further configuration changes will be needed to add Jest tests.
|
More conflicts to resolve. Moving into draft (CI passes but it shouldn't, this is reducing test coverage). |
Gudahtt
changed the title
vthomas13
reviewed
Jun 24, 2024
| '<rootDir>/app/scripts/migrations/*.ts', | ||
| '!<rootDir>/app/scripts/migrations/*.test.(js|ts)', | ||
| '<rootDir>/app/scripts/platforms/*.js', | ||
| '<rootDir>/app/scripts/**/*.(js|ts|tsx)', |
vthomas13
approved these changes
Jun 24, 2024
danjm
approved these changes
Jun 24, 2024
github-actions
bot
removed
the
needs-dev-review
metamaskbot
added
the
release-12.1.0
Builds ready [dda8b8c]
Page Load Metrics (45 ± 4 ms)
Bundle size diffs
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our Mocha and Jest configuration has been messy because we're in the middle of a migration from Mocha to Jest. Each file had to be explicitly included in the Jest configuration or ignored in the Mocha configuration. This was inconvenient and error-prone, and resulted in some tests not being run at all.
Both test configurations have been updated to use a shared list of Mocha test files. There are only a few of these files left, and this list should only get shorter as we migrate more tests to Jest. No further configuration changes will be needed to add Jest tests.We have now finished migrating unit tests from Mocha to Jest, so this PR now only affects the Jest configuration.
Note that the ESLint configuration has not been updated to use these simpler globs to determine which tests use Mocha and which use Jest. I tried doing that in this PR initially but it raised too many lint errors, so that will come in a later PR. In the meantime, we may still need to update
.eslintrc.jswhen adding a new test of either type.Related issues
N/A
Manual testing steps
Run
yarn test:unitand verify that it runs correctly (no errors, no missing tests)Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist