Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds linea mainnet buyable support in anticipation of July 11 launch #19854

Merged
merged 8 commits into from
Jul 7, 2023
Merged

feat: adds linea mainnet buyable support in anticipation of July 11 launch #19854

Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
466376f
feat: adds linea mainnet support in anticipation of July 11 launch
georgeweiler Jun 28, 2023
56f6f0b
Merge branch 'develop' into feature/onramp-linea-support
georgeweiler Jun 30, 2023
44c16b3
chore: fixes linting issue
georgeweiler Jun 30, 2023
fbefe63
Merge branch 'develop' into feature/onramp-linea-support
georgeweiler Jul 1, 2023
1b768bb
Merge branch 'feature/onramp-linea-support' of https://github.com/Met…
georgeweiler Jul 1, 2023
f5c6ec9
chore: adds comma for linting
georgeweiler Jul 1, 2023
60dc6a9
Merge branch 'develop' into feature/onramp-linea-support
wachunei Jul 5, 2023
3c60dc6
Merge branch 'develop' into feature/onramp-linea-support
danjm Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion shared/constants/network.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,7 +548,6 @@ export const BUYABLE_CHAINS_MAP: {
| typeof CHAIN_IDS.FANTOM_TESTNET
| typeof CHAIN_IDS.MOONBEAM_TESTNET
| typeof CHAIN_IDS.LINEA_GOERLI
| typeof CHAIN_IDS.LINEA_MAINNET
| typeof CHAIN_IDS.GOERLI
>]: BuyableChainSettings;
} = {
Expand Down Expand Up @@ -612,6 +611,10 @@ export const BUYABLE_CHAINS_MAP: {
nativeCurrency: CURRENCY_SYMBOLS.PALM,
network: 'palm',
},
[CHAIN_IDS.LINEA_MAINNET]: {
nativeCurrency: CURRENCY_SYMBOLS.ETH,
Copy link
Contributor

@legobeat legobeat Jul 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the chain have its own symbol to reduce risk of confusion and misdirection?

#19911 addresses this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was expecting as an L2 that we use ETH just like Optimism does, can we confirm this with linea team?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correspondingly: #19912

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't that make the native ticker be OP? 🤔 this is currently ETH even in their block tracker since OP is an ERC-20
image

network: 'linea',
},
};

export const FEATURED_RPCS: RPCDefinition[] = [
Expand Down
Loading