feat: adds linea mainnet buyable support in anticipation of July 11 launch #19854

georgeweiler · 2023-06-30T16:42:31Z

Explanation

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-merge author checklist

I've clearly explained:
- What problem this PR is solving
- How this problem was solved
- How reviewers can test my changes
Sufficient automated test coverage has been added

Pre-merge reviewer checklist

Manual testing (e.g. pull and build branch, run in browser, test code being changed)
PR is linked to the appropriate GitHub issue
IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

github-actions · 2023-06-30T16:42:42Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

georgeweiler · 2023-06-30T16:43:49Z

I have read the CLA Document and I hereby sign the CLA

…aMask/metamask-extension into feature/onramp-linea-support

codecov · 2023-07-01T22:14:30Z

Codecov Report

Merging #19854 (f5c6ec9) into develop (945508c) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head f5c6ec9 differs from pull request most recent head 60dc6a9. Consider uploading reports for the commit 60dc6a9 to get more accurate results

@@             Coverage Diff             @@
##           develop   #19854      +/-   ##
===========================================
- Coverage    69.70%   69.68%   -0.02%     
===========================================
  Files          982      982              
  Lines        37054    37067      +13     
  Branches      9937     9941       +4     
===========================================
+ Hits         25827    25829       +2     
- Misses       11227    11238      +11

Impacted Files	Coverage Δ
shared/constants/network.ts	`100.00% <ø> (ø)`

... and 16 files with indirect coverage changes

metamaskbot · 2023-07-01T22:22:50Z

Builds ready [f5c6ec9]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1636 ± 56 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	109	171	131	16	8
		domContentLoaded	1474	1847	1634	114	55
		load	1475	1871	1636	117	56
		domInteractive	1474	1847	1634	114	55

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 bytes
ui: 0 bytes
common: 57 bytes

legobeat · 2023-07-07T07:05:50Z

shared/constants/network.ts

@@ -612,6 +611,10 @@ export const BUYABLE_CHAINS_MAP: {
    nativeCurrency: CURRENCY_SYMBOLS.PALM,
    network: 'palm',
  },
+  [CHAIN_IDS.LINEA_MAINNET]: {
+    nativeCurrency: CURRENCY_SYMBOLS.ETH,


Shouldn't the chain have its own symbol to reduce risk of confusion and misdirection?

#19911 addresses this.

I was expecting as an L2 that we use ETH just like Optimism does, can we confirm this with linea team?

Correspondingly: #19912

Wouldn't that make the native ticker be OP? 🤔 this is currently ETH even in their block tracker since OP is an ERC-20

metamaskbot · 2023-07-07T09:22:24Z

Builds ready [3c60dc6]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1564 ± 38 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	108	147	124	11	5
		domContentLoaded	1389	1706	1564	80	38
		load	1389	1706	1564	80	38
		domInteractive	1389	1706	1564	80	38

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 bytes
ui: 0 bytes
common: 57 bytes

feat: adds linea mainnet support in anticipation of July 11 launch

466376f

georgeweiler requested a review from a team as a code owner June 30, 2023 16:42

georgeweiler added 5 commits June 30, 2023 10:44

Merge branch 'develop' into feature/onramp-linea-support

56f6f0b

chore: fixes linting issue

44c16b3

Merge branch 'develop' into feature/onramp-linea-support

fbefe63

Merge branch 'feature/onramp-linea-support' of https://github.com/Met…

1b768bb

…aMask/metamask-extension into feature/onramp-linea-support

chore: adds comma for linting

f5c6ec9

Merge branch 'develop' into feature/onramp-linea-support

60dc6a9

danjm added release-blocker This bug is blocking the next release release-10.34.0 Issue or pull request that will be included in release 10.34.0 labels Jul 5, 2023

danjm approved these changes Jul 6, 2023

View reviewed changes

DDDDDanica approved these changes Jul 7, 2023

View reviewed changes

pedronfigueiredo approved these changes Jul 7, 2023

View reviewed changes

legobeat reviewed Jul 7, 2023

View reviewed changes

legobeat mentioned this pull request Jul 7, 2023

fix/19854: Set Linea nativeCurrency symbol to LINEAETH #19911

Closed

Merge branch 'develop' into feature/onramp-linea-support

3c60dc6

danjm merged commit 90bfbf2 into develop Jul 7, 2023
9 checks passed

danjm deleted the feature/onramp-linea-support branch July 7, 2023 09:29

github-actions bot locked and limited conversation to collaborators Jul 7, 2023

metamaskbot added the release-10.35.0 Issue or pull request that will be included in release 10.35.0 label Jul 7, 2023

PeterYinusa removed the release-10.35.0 Issue or pull request that will be included in release 10.35.0 label Jul 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: adds linea mainnet buyable support in anticipation of July 11 launch #19854

feat: adds linea mainnet buyable support in anticipation of July 11 launch #19854

georgeweiler commented Jun 30, 2023 •

edited

Loading

github-actions bot commented Jun 30, 2023 •

edited

Loading

georgeweiler commented Jun 30, 2023

codecov bot commented Jul 1, 2023 •

edited

Loading

metamaskbot commented Jul 1, 2023

legobeat Jul 7, 2023 •

edited

Loading

wachunei Jul 10, 2023

legobeat Jul 10, 2023

wachunei Jul 10, 2023

metamaskbot commented Jul 7, 2023

feat: adds linea mainnet buyable support in anticipation of July 11 launch #19854

feat: adds linea mainnet buyable support in anticipation of July 11 launch #19854

Conversation

georgeweiler commented Jun 30, 2023 • edited Loading

Explanation

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jun 30, 2023 • edited Loading

georgeweiler commented Jun 30, 2023

codecov bot commented Jul 1, 2023 • edited Loading

Codecov Report

metamaskbot commented Jul 1, 2023

legobeat Jul 7, 2023 • edited Loading

Choose a reason for hiding this comment

wachunei Jul 10, 2023

Choose a reason for hiding this comment

legobeat Jul 10, 2023

Choose a reason for hiding this comment

wachunei Jul 10, 2023

Choose a reason for hiding this comment

metamaskbot commented Jul 7, 2023

georgeweiler commented Jun 30, 2023 •

edited

Loading

github-actions bot commented Jun 30, 2023 •

edited

Loading

codecov bot commented Jul 1, 2023 •

edited

Loading

legobeat Jul 7, 2023 •

edited

Loading