Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hpcinfra 2572 secrets scanner on doca xlio #236

Conversation

vialogi
Copy link
Contributor

@vialogi vialogi commented Sep 19, 2024

Description

We update references to Jenkins's secrets

What

We update CI with updated Jenkins secrets references

Why ?

Secrets Scanner does not work correctly with the old secrets format

Change type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

Check list

  • Code follows the style de facto guidelines of this project
  • Comments have been inserted in hard to understand places
  • Documentation has been updated (if necessary)
  • Test has been added (if possible)

@vialogi vialogi changed the base branch from master to doca_xlio September 19, 2024 12:23
We need to rename Jenkins secrets IDs to human readable form.

Jenkins secrets we reference in the CI are currently represented in UUID format.
It confuses Secrets Scanner, which takes these data for passwords.

Renaming these secret IDs in Jenkins will allow us to restor Secrets Scanner normal workflow.

issue: HPCINFRA-2572

Signed-off-by: Viacheslav Login <[email protected]>
@vialogi vialogi force-pushed the HPCINFRA-2572_secrets_scanner_on_doca_xlio branch from ff147b0 to 7252378 Compare September 21, 2024 05:36
@dpressle dpressle closed this Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants