Skip to content

Commit

Permalink
[CI]: fixing false positives in the Secrets Scanner
Browse files Browse the repository at this point in the history
We need to rename Jenkins secrets IDs to human readable form.

Jenkins secrets we reference in the CI are currently represented in UUID format.
It confuses Secrets Scanner, which takes these data for passwords.

Renaming these secret IDs in Jenkins will allow us to restor Secrets Scanner normal workflow.

issue: HPCINFRA-2572

Signed-off-by: Viacheslav Login <[email protected]>
  • Loading branch information
vialogi committed Sep 19, 2024
1 parent 92e6e30 commit ff147b0
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions .ci/matrix_job.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ job: LIBXLIO
step_allow_single_selector: false

registry_host: harbor.mellanox.com
registry_auth: 1daaea28-800e-425f-a91f-3bd3e9136eea
registry_auth: swx-infra_harbor_credentials
registry_path: /swx-infra/media

kubernetes:
Expand All @@ -16,7 +16,7 @@ kubernetes:
requests: '{memory: 10Gi, cpu: 10000m}'

credentials:
- {credentialsId: '925b0900-e273-4042-bc7c-facaefae0727', usernameVariable: 'XLIO_COV_USER', passwordVariable: 'XLIO_COV_PASSWORD'}
- {credentialsId: 'media_coverity_credentials', usernameVariable: 'XLIO_COV_USER', passwordVariable: 'XLIO_COV_PASSWORD'}

volumes:
- {mountPath: /hpc/local/bin, hostPath: /hpc/local/bin}
Expand Down Expand Up @@ -255,7 +255,7 @@ steps:
- name: Coverity
enable: ${do_coverity}
credentialsId: '925b0900-e273-4042-bc7c-facaefae0727'
credentialsId: 'media_coverity_credentials'
containerSelector:
- "{name: 'toolbox', category: 'tool'}"
agentSelector:
Expand Down Expand Up @@ -396,7 +396,7 @@ steps:
reportName: "BlackDuck report"
scanMode: "source"
skipDockerDaemonCheck: true
credentialsId: "b68aedbd-e39f-4ee2-acce-e25a5b91fe18"
credentialsId: "swx-jenkins3-svc_git-nbu_token"
env:
SPRING_APPLICATION_JSON: '{"blackduck.url":"https://blackduck.mellanox.com/","blackduck.api.token":"ODMwOWYwMzEtODA2ZC00MzBjLWI1ZDEtNmFiMjBkYzQzMzkwOjNmNjExN2M1LWE2ZmEtNDZlYS1hZjRiLTZlNDgwNjAwOTVjNw=="}'

Expand Down
4 changes: 2 additions & 2 deletions .ci/opensource_jjb.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@
failure-status: "[FAIL]"
error-status: "[FAIL]"
status-add-test-results: true
auth-id: '2806c206-c725-4d8c-af4b-bedfc463b401'
auth-id: 'swx-jenkins5_gh_token'
org-list: ["Mellanox"]
white-list: ["swx-jenkins","swx-jenkins2","swx-jenkins3","mellanox-github"]
allow-whitelist-orgs-as-admins: true
Expand All @@ -129,7 +129,7 @@
scm:
- git:
url: "{jjb_git}"
credentials-id: 'b7d08ca7-378c-45d6-ac4b-3f30bdf49168'
credentials-id: 'swx-jenkins_ssh_key'
branches: ['$sha1']
shallow-clone: true
depth: 2
Expand Down

0 comments on commit ff147b0

Please sign in to comment.