-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated scripts to build, run, test all sample projects #247
Conversation
rheiland
commented
Jun 5, 2024
- this bash script compiles all (non-intracellular) sample projects and creates user_projects of each, preparing for the next step of running (brief) simulations of each.
I'm trying this out to test the arg parser and noticing the template project produces a file called Right now, I'm just appending an underscore to the executable name. bonus: that could be used to more easily delete at command line? Better is probably to prefix with an underscore so sorting puts them together. affected projects:
|
Thanks very much! Pushed a fix. May go with a prefix or suffix underscore in the future, but for now staying with more traditional naming scheme. The header of the script lists all execs' names too. |
I am still more familiar with python than bash. like this, it would be more or less easy to have a unified Makefile, or do changes to the unified Makefile structure. |
I just pushed |
Amazing! This will be so nice for testing!! Did you consider calling the bash script from the python script to make sure the user_projects are properly populated? It seems that would be useful, but would be interested in your thoughts. I'm sure I could add that with copilot really easily in the bash script if you think that's a good idea. |
I think I'd like to keep them as separate scripts for now. I guess I should add comments in each to make it clear. |
beta/test_run_samples.py
Outdated
import os | ||
import time | ||
|
||
# skip over the 3D cancer_immune_sample for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add context so we know when to include that project in testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since you said you should add comments to it, I would also appreciate clarity on this one :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've pushed edits which includes running that 3D cancer_immune project now. Also note that the physimess project will have an error due to not having a cp -r
in the make load ...
(only until 1.14.0 is released, hopefully), thereby preventing it from compiling and running.
Just added a 3rd and final(?) script for testing:
|
There appear to be no conflicts. |