Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix PhysiCell constants for more compilers #248

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

rheiland
Copy link
Collaborator

@rheiland rheiland commented Jun 5, 2024

This may be premature, but would like to at least suggest it get merged in this release. This addresses compiler errors with PhysiCell_constants{.h,.cpp} for certain compilers (I had mentioned clang++ when I need to do serious debugging, and issue #236 mentioned the error on nvc++, as did @clasqui to @vincent-noel for PhysiBoSS).

I've only tested with the "compile all the sample projects" script. Obviously, it would be good to test with actual simulations (EDIT: see next comment).

@rheiland
Copy link
Collaborator Author

I used the 3 scripts discussed in #247 to verify that the results generated using the modified versions of core/PhysiCell_constants.{h,cpp} in this PR's repo matched (bitwise) the simulation results using the core/PhysiCell_constants.{h,cpp} in 1.13.1

Specifically, I ran this 3rd script (after running its 2 predecessor scripts to generate simulation results):
M1P~/git/new-build-test$ python beta/test_diffs_svg.py ~/git/new-build-test/samples_test ~/git/fix-constants/samples_test
and it confirmed that the (early) .svg results were bitwise reproducible for these sample models:

# note that we omit 'output_physimess' only because, currently, it fails the recursive copy of
# additional files needed in config/subdirs (until the Makefiles and "make load PROJ" is updated)

for out_dir in ['output_template','output_biorobots','output_cancer_biorobots','output_celltypes3',
'output_heterog','output_interaction','output_mechano','output_pred_prey','output_virus_mac',
'output_worm','output_rules','output_cancer_immune']:

@rheiland
Copy link
Collaborator Author

rheiland commented Jun 27, 2024

I also confirmed that nvc++ compiles without any errors (on Ubuntu). It's actually enlightening to see the warnings that it returns which hint at some code cleanup that could be done.

@vincent-noel
Copy link
Collaborator

Works on my ubuntu too

@rheiland rheiland mentioned this pull request Aug 15, 2024
@MathCancer MathCancer merged commit 794c91d into MathCancer:development Aug 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants