Extract some of #3360 fixes to 10.5.x #3485
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Riddle me this, some runners doesn’t understand Update: Riddle me this, it’s the same error as that one and that tweak works here too. |
ParadoxV5
force-pushed
the
10.5-my_snprintf
branch
from
938e262
to
eca5a6f
Compare
|
The Buildbot failure is |
ParadoxV5
added a commit
to ParadoxV5/MariaDB-server
that referenced
this pull request
Sep 1, 2024
That PR uncovered countless issues on `my_snprintf` uses. This commit backports a squashed subset of their fixes (excludes MariaDB#3485).
3 tasks
ParadoxV5
force-pushed
the
10.5-my_snprintf
branch
from
eca5a6f
to
c56a501
Compare
ParadoxV5
added a commit
to ParadoxV5/MariaDB-server
that referenced
this pull request
Sep 13, 2024
That PR uncovered countless issues on `my_snprintf` uses. This commit backports a squashed subset of their fixes. (Excludes previous parts MariaDB#3485 and MariaDB#3493)
3 tasks
That PR uncovered countless issues on `my_snprintf` uses. This commit backports a squashed subset of their fixes.
ParadoxV5
force-pushed
the
10.5-my_snprintf
branch
from
c56a501
to
562f5a6
Compare
ParadoxV5
added a commit
to ParadoxV5/MariaDB-server
that referenced
this pull request
Sep 14, 2024
That PR uncovered countless issues on `my_snprintf` uses. This commit backports a squashed subset of their fixes. (Excludes previous parts MariaDB#3485 and MariaDB#3493)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Jira issue number for this PR is: MDEV-21978While this code originates from my GSoC project, this publication (i.e., commit and PR descriptions) isn’t.
Description
#3360 uncovered countless potential minor security vulnerabilities on
my_snprintfuses.This commit ports a squashed subset of their fixes according to the bug-fixing process to 10.5, our oldest maintained version.
(My GSoC mentor said that they aren’t much of a problem and I can open a PR normally.)
Most
size_ts were still simpleuints back here, though I didn’t include their changes from%dto%uso this commit doesn’t conflict when merging up. The exception issql/table.ccwith its large chuncks of diffs from reformatting.After all, I expect users to upgrade to the newer versions sooner or later.
Similarly, while 10.5 may have had other issues in this category that are obsolete in 11.6 (the branch from which the superset was based on), I am not goïng to hunt them down.
Release Notes
Nothing?These internal corrections shouldn’t be user-visible (other than perhaps one fewer crashes).
How can this PR be tested?
I’m not certain how we could catch these human errors besides testing #3360 (MDEV-21978) and syncing this PR with it.
Basing the PR against the correct MariaDB version
mainbranch.PR quality check