Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract some of #3360 fixes to 10.11.x #3518

Open
wants to merge 1 commit into
base: 10.11
Choose a base branch
from

Conversation

ParadoxV5
Copy link

@ParadoxV5 ParadoxV5 commented Sep 13, 2024

Description

#3360 uncovered countless potential minor security vulnerabilities on my_snprintf uses.
This commit ports a squashed subset of their fixes according to the bug-fixing process to 10.11, covering cases that weren’t applicable for 10.5 (#3485) and 10.6 (#3493).
(My GSoC mentor said that they aren’t much of a problem and I can open a PR normally.)

Similar to the previous iterations, I haven’t searched issues obsolete in 11.6.

Release Notes

  • Fixed data size mismatches that were garbling outputs (or possibly even crashes) on problematic platforms – mostly on error messages and debug logs

How can this PR be tested?

I’m not certain how we could catch these human errors besides testing #3360 (MDEV-21978) and syncing this PR with it.

Basing the PR against the correct MariaDB version

  • This is a new feature or a refactoring, and the PR is based against the main branch.
  • This is a bug fix, and the PR is based against the earliest maintained branch in which the bug can be reproduced.

PR quality check

  • I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

That PR uncovered countless issues on `my_snprintf` uses.
This commit backports a squashed subset of their fixes.
(Excludes previous parts MariaDB#3485 and MariaDB#3493)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant