MDEV-30482 libmariadb3 - debian/libmariadb3.symbols not updated #2780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grooverdan
added
the
MariaDB Foundation
|
This looks correct, thanks! I will try to debug why buildbot does not fail on builds before this commit as clearly the actual ABI and expected ABI has a mismatch (before this change). |
|
I think debian being lenient of symbols added and then just assuming the package name is the version added for ease of update. if you're not worried about the version added part of the symbol file being potentially a version or two incorrect as it was hard too look up. I'll double check after some sleep we came to the right ABI version as that probably matters most. Sorry for the dup - long flight without internet |
|
I checked the buildlog from this PR at https://buildbot.mariadb.org/#/builders/148/builds/26707 - it does indeed fail on the step that checks ABI tracking: I checked the mainline 11.3 builds for latest commit at https://buildbot.mariadb.org/#/builders/148/builds/26603 and it reveals: However it is not failing. Maybe something on buildbot is fiddling with DPKG_GENSYMBOLS_CHECK_LEVEL to prevent it from failing the build. |
|
thanks for exaction and check level reference. |
grooverdan
force-pushed
the
bb-MDEV-30482-libmariadb3-symbols-deb
branch
from
4196156
to
6689c16
Compare
|
this is now fixed with |
|
You probably want to have as commit title "MDEV-30482: Add missing symbols and their introduced C/C version" and rebase instead of having merge commits in a merge request. I checked https://buildbot.mariadb.org/#builders/148/builds/27096 and |
grooverdan
added a commit
to grooverdan/mariadb-buildbot
that referenced
this pull request
Oct 19, 2023
Ensure that symbols aren't removed and are documented when added to ensure consistency. Same to enable when MariaDB/server#2780 is merged up to the latest.
|
the merges are from the update branch and get removed when merged. The original commit is further up. MariaDB/buildbot#197 is ready to enforce this. Acceptable? |
|
Note that 10.10 is end of life, so we cannot merge. Might want to move this to 10.11. |
Add missing symbols and their introduced C/C version.
grooverdan
force-pushed
the
bb-MDEV-30482-libmariadb3-symbols-deb
branch
from
45b585f
to
76c74fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add missing symbols and their introduced C/C version.
@ottok see you added this in #2778. Some of our version number differ. I didn't look down to 3.1 so your introduced version of this is likely more accurate.
Is it a FYI field in the debian packaging?
How can this PR be tested?
deb-autobake tests (check output, won't fail I think)
Basing the PR against the correct MariaDB version
PR quality check