Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dpkg gensymbols check #197

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Dpkg gensymbols check #197

wants to merge 2 commits into from

Conversation

grooverdan
Copy link
Member

No description provided.

@grooverdan
deb_autobake - DPKG_GENSYMBOLS_CHECK_LEVEL=4 to autocheck MDEV-30482
1687e6f 
Ensure that symbols aren't removed and are documented when added to
ensure consistency.

Same to enable when MariaDB/server#2780 is
merged up to the latest.
@grooverdan
Black format master.cfg
e826ff5
@grooverdan grooverdan mentioned this pull request Oct 19, 2023
Merged
5 tasks
@grooverdan
Copy link
Member Author

when MariaDB/server#2780 is
merged up to the latest.

I see Black formatting when too far.

@fauust fauust force-pushed the main branch 3 times, most recently from 8b053e1 to 93d9479 Compare October 20, 2023 10:40
@grooverdan grooverdan marked this pull request as draft October 20, 2023 12:24
@ottok
Copy link
Contributor

ottok commented Jan 21, 2024

This is perhaps not needed to enforce MariaDB/server#2780 if one simply updates the debian/rules section to have same as downstream Debian:

# Only do a strict symbol checking on Linux
# https://manpages.debian.org/testing/dpkg-dev/dpkg-gensymbols.1.en.html
# Level 4: Fails if some libraries have been introduced.
ifneq (,$(filter linux,$(DEB_HOST_ARCH_OS)))
    export DPKG_GENSYMBOLS_CHECK_LEVEL = 4
endif

(from https://salsa.debian.org/mariadb-team/mariadb-server/-/commit/f2fe8d8300642c373ce325f19d1100d79adeed45)

FYI In case e.g. @illuusio wants to upstream improvements in Debian.

@illuusio
Copy link
Contributor

illuusio commented Jan 22, 2024 •
edited
Loading

This is little bit hair picking but I fairly hard to find change from those ' --> " changes and other indentation changes. Could they be done in other PR? Should we favor @ottok approach and move it to rules? Or it this just for some Ubuntu / Debian versions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grooverdan @ottok @illuusio