Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing legacy binds was deprecated in 6.1 and removed in 7. #22886

Merged

Conversation

jrafanie
Copy link
Member

@jrafanie jrafanie commented Feb 7, 2024

See: rails/rails@92360e9

Extracted from #22873

Note, this failed with rails 7 when running RAILS_ENV=test bundle exec rails db:environment:set evm:db:reset. This is backward compatible with rails 6.1.

@miq-bot
Copy link
Member

miq-bot commented Feb 7, 2024

Checked commit jrafanie@74c7a32 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@Fryguy Fryguy merged commit 6401cf1 into ManageIQ:master Feb 7, 2024
8 checks passed
@Fryguy Fryguy self-assigned this Feb 7, 2024
@jrafanie jrafanie deleted the legacy_binds_support_dropped_in_rails7 branch February 7, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants