Upgrade to rails 7.0

[jrafanie]

Here's an issue we can link to for all future PRs and work items relating to upgrading to rails 7.

Follow up work now that rails 7 is shipped and 6.1 is dropped - mostly not backward compatible with rails 6.1.

• Change default rails version for new schema migrations to rails 7. We'll do this when we need to use a new feature. There is no rush since they keep schema backward compatibity for even EOL rails versions.
• Use uglifier harmony mode to handle es6 syntax with rails 7 manageiq-ui-classic#9244
• Wrap the uglifier compressor with harmony support manageiq-ui-classic#9245
• Rails 7 - cpu_usage_rate_average should be a numeric, not a string. manageiq-consumption#220
• Rails7 test fixes manageiq-ui-classic#9231
• Normalize the various ways we did the yaml permitted classes or just drop the 6.1 way, once we ship rails 7. Based on comments from Provide backward compatible way to globally set permitted classes manageiq-providers-kubernetes#531 (comment). See:
  • Use Rails 7 way to set yaml permitted classes #23133
  • Use Rails 7 way to set yaml permitted classes manageiq-providers-kubernetes#536
  • Use Rails 7 way to set yaml permitted classes manageiq-providers-openstack#888
  • Use Rails 7 way to set yaml permitted classes manageiq-ui-classic#9243
• Update code coverage to latest ruby/rails: Update code coverage to use rails 7 and ruby 3.1 #23132
• Don't STI load via the descendants/subclasses hooks during code reload #23134

Completed

• Main PR: Rails 7 #22873
  • DescendantLoader hooks subclasses/descendants which were changed in rails 7. We need a different way to do this with rails 7. See the changes to descendant_loader.rb in the main PR.
• Virtual attributes needs to support rails 7. Activerecord preloader in rails 7 was rewritten and needs to be changed for usage with virtual attributes.
  • Add rails 7.0 support and drop rails 6.1 activerecord-virtual_attributes#150, previously was [WIP] Support Rails 7.0 activerecord-virtual_attributes#133
  • activerecord-virtual_attributes 7.0.0 released
• Change remaining repositories to test with both rails 6.1 and 7
• Move to AS::DescendantsTracker.subclasses #23108
• Rails7 fixes manageiq-api#1263
• Rails 7 mvp (just get it runnable with rails 7) activerecord-virtual_attributes#146
• Rails7 friendly require during initializers #23102
• Use default_value_for 4.0 with rails 7+ support #23093
• Don't attempt to load SettingsChange too early #23096
• Rails 7 compatible changes (part 1) manageiq-ui-classic#9215
• Fix rails 7 deprecation #23083
• default_value_for 3.5.0 and 3.6.0 were released with rails 7 and 7.1 support: Support for Rails 7 FooBarWidget/default_value_for#92)
• Provide backward compatible way to globally set permitted classes manageiq-providers-openstack#885
• Provide backward compatible way to globally set permitted classes manageiq-providers-kubernetes#531
• Prepend ActionView::Helpers::NumberHelper with our NumberHelper manageiq-ui-classic#9119
• Failed rails 7 schema tests due to new behavior in rails 7 of migration classes being removed and reloaded between migrations Allow rails 7 gems in gemspec manageiq-schema#715
• Backward compatible rails 7 changes manageiq-schema#735
• Rails 7 removed clear_association_cache #22885
• require logger to avoid autoload during rails boot manageiq-automation_engine#539
• Fix rails 6.1 errors is now array warnings manageiq-ui-classic#8408
• Fix rails 6.1 errors is now array warnings #22050
• Use config option in 6.1.7+ instead of an initializer #22852
• Setup Settings constant before the database is connected #22853
• connection_config was removed in rails 7 #22884
• Passing legacy binds was deprecated in 6.1 and removed in 7. #22886
• Provide backward compatible way to globally set permitted classes #22887
• Allow rails 7 in independent gems, add both ruby 3.1 and rails 7 to the test matrix
  • Fix rails 7 deprecation on ActiveRecord::Base.default_timezone inventory_refresh#124 (not required - deprecation fix)
  • Allow rails 7 gems in gemspec activerecord-id_regions#33
  • Allow rails 7 gems in gemspec inventory_refresh#119
  • Allow rails 7 gems in gemspec manageiq-api-client#114
  • Allow rails 7 gems in gemspec manageiq-appliance_console#226
  • Add ruby 3.1 to the test matrix manageiq-appliance_console#227
  • Allow rails 7 gems in gemspec manageiq-gems-pending#570
  • Add ruby 3.1 to the test matrix manageiq-gems-pending#571
  • Allow rails 7 gems in gemspec manageiq-messaging#83
  • Add ruby 3.1 to the test matrix manageiq-messaging#84
  • Allow rails 7 gems in gemspec manageiq-postgres_ha_admin#43
  • Allow rails 7 gems in gemspec manageiq-providers-openstack#868
  • Allow rails 7 gems in gemspec manageiq-ui-classic#9027
  • Allow rails 7 gems in gemspec ovirt_metrics#48
  • Allow rails 7 gems in gemspec vmware_web_service#126
  • Add ruby 3.1 to the test matrix vmware_web_service#127
• New gem releases
  • (0.4.0) activerecord-id_regions for Allow rails 7 gems in gemspec activerecord-id_regions#33 (needed by schema)
    • Remove some/all usage of default_value_for: Replace "some" default_value_for usage #22901 (comment)
  • (0.5.0) manageiq-api-client for Allow rails 7 gems in gemspec manageiq-api-client#114
  • (1.4.2) manageiq-messaging for Allow rails 7 gems in gemspec manageiq-messaging#83 and Add ruby 3.1 to the test matrix manageiq-messaging#84
  • (3.3.0) manageiq-postgres_ha_admin for Allow rails 7 gems in gemspec manageiq-postgres_ha_admin#43
  • (2.1.0) inventory_refresh for Allow rails 7 gems in gemspec inventory_refresh#119
  • Set inventory refresh minimum version to support rails 7 #22892
  • (8.1.0) manageiq-appliance_console for Allow rails 7 gems in gemspec manageiq-appliance_console#226 and Add ruby 3.1 to the test matrix manageiq-appliance_console#227
  • (3.2.0) ovirt_metrics for Allow rails 7 gems in gemspec ovirt_metrics#48 (needed by the provider)
  • Set minimum version to support rails 7 manageiq-providers-red_hat_virtualization#41
  • Set minimum version to support rails 7 manageiq-providers-ovirt#657
  • (3.3.0) vmware_web_service for Allow rails 7 gems in gemspec vmware_web_service#126 and Add ruby 3.1 to the test matrix vmware_web_service#127
  • Set minimum version to support rails 7 manageiq-providers-vmware#899
• Switch interlock/zeitwerk check to be a rails 7 check so we can drop it when we drop 6.1
  • loading is not needed with zeitwerk autoloader manageiq-api#1243
  • permit_concurrent_loads is not needed with zeitwerk autoloader manageiq-automation_engine#537
  • There can be only one autoloader: zeitwerk #22801
• Remove usage of include_concern and require_nested
  • Drop include_concern manageiq-api#1246
  • Drop include_concern manageiq-consumption#213
  • Drop require_nested and include_concern manageiq-providers-amazon#838
  • Drop require_nested manageiq-providers-ansible_tower#303
  • Drop require_nested manageiq-providers-autosde#242
  • Drop require_nested manageiq-providers-awx#23
  • Drop require_nested and include_concern manageiq-providers-azure#546
  • Drop require_nested manageiq-providers-azure_stack#102
  • Drop require_nested and include_concern manageiq-providers-cisco_intersight#105
  • Drop require_nested and include_concern manageiq-providers-foreman#123
  • Drop require_nested and include_concern manageiq-providers-google#258
  • Drop require_nested manageiq-providers-ibm_cic#43
  • Drop require_nested and include_concern manageiq-providers-ibm_cloud#482
  • Drop require_nested and include_concern manageiq-providers-ibm_power_hmc#151
  • Drop require_nested manageiq-providers-ibm_power_vc#101
  • Drop require_nested manageiq-providers-ibm_terraform#101
  • Drop require_nested manageiq-providers-kubernetes#514
  • Drop require_nested and include_concern manageiq-providers-kubevirt#227
  • Drop require_nested and include_concern manageiq-providers-lenovo#400
  • Drop require_nested manageiq-providers-nsxt#97
  • Drop require_nested manageiq-providers-nuage#304
  • Drop require_nested  manageiq-providers-openshift#253
  • Drop require_nested and include_concern manageiq-providers-openstack#871
  • Drop require_nested manageiq-providers-oracle_cloud#95
  • Drop require_nested and include_concern manageiq-providers-ovirt#656
  • Drop require_nested and include_concern manageiq-providers-red_hat_virtualization#40
  • Drop require_nested and include_concern manageiq-providers-redfish#187
  • Drop require_nested and include_concern manageiq-providers-vmware#898
  • Drop require_nested manageiq-providers-workflows#69
  • Drop include_concern manageiq-ui-classic#9060
  • Deprecate and remove usage of include_concern and require_nested #22854

[miq-bot]

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

[Fryguy]

@jrafanie Is this done? If so can we close and move it to the Radjabov column in the roadmap?

[jrafanie]

@jrafanie Is this done? If so can we close and move it to the Radjabov column in the roadmap?

I've been adding bugs to the list so it's all in one place but yes, the feature is done. Maybe once we have smoke test, we can close it for real.

[jrafanie]

Let's just close this. I think we should decide to change new schema migrations to use 7.0 when we decide we want to do this. They always keep compatibility with old schema versions so we should upgrade to 7.0 schema for new migrations when we have a feature reason to do so.