-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide backward compatible way to globally set permitted classes #531
Provide backward compatible way to globally set permitted classes #531
Conversation
This supports rails 7 and 6.1. Similar to the change in: ManageIQ/manageiq#22887
Checked commit jrafanie@5a6dfc0 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
Minor, but can we
My main concerns are duplication of code and then being able to find all those later when we need to undo it. |
Actually i said spec/support but the original code is in yaml_permitted_classes, so maybe it's just easy to refactor into another method on that module and use it here. Just trying to avoid the duplication. |
Sure, I'll add a follow up item to the rails 7 todo list to find a generic way for all of the various repos to do the same function. Or maybe just delete the rails 6.1 way when it's dropped. Currently debugging tough api and ui-classic test failures so cleanup is less priority. |
ok, I added a followup item to ManageIQ/manageiq#22052 |
@Fryguy this is ready to go. I'll come back and clean these up in the follow task: ManageIQ/manageiq#22052. When we drop rails 6.1, it should be easy to mass remove them. |
Drops the rails 6.1 compatibility from: ManageIQ#531
This supports rails 7 and 6.1.
Similar to the change in: ManageIQ/manageiq#22887