Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continuation of polar axis #2990

Merged
merged 72 commits into from
Jul 18, 2023
Merged

Continuation of polar axis #2990

merged 72 commits into from
Jul 18, 2023

Commits on Jun 28, 2022

  1. start implementation

    @jkrumbiegel @asinghvi17
    jkrumbiegel authored and asinghvi17 committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    ba2318a View commit details
    Browse the repository at this point in the history

  2. First implementation of polar axis 

    The theme should be mostly set, grids exist but ticks need to be plotted.
    @asinghvi17
    asinghvi17 committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    ad8900c View commit details
    Browse the repository at this point in the history

  3. Try to make the polar axis "plottable-to"

    @asinghvi17
    asinghvi17 committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    9f662fb View commit details
    Browse the repository at this point in the history

  4. Revert MakieLayout.jl to master state

    @asinghvi17
    asinghvi17 committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    828c9a4 View commit details
    Browse the repository at this point in the history

  5. Correct documentation of adjustcam!

    @asinghvi17
    asinghvi17 committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    be9302b View commit details
    Browse the repository at this point in the history

  6. Implement angular ticks

    @asinghvi17
    asinghvi17 committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    8a1d0a6 View commit details
    Browse the repository at this point in the history

  7. Inherit a bit more

    @asinghvi17
    asinghvi17 committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    9f2c0a3 View commit details
    Browse the repository at this point in the history

  8. Implement radial ticks

    @asinghvi17
    asinghvi17 committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    8c2dc4b View commit details
    Browse the repository at this point in the history

  9. Fix translation for GLMakie

    @asinghvi17
    asinghvi17 committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    3d0f20c View commit details
    Browse the repository at this point in the history

  10. In Camera2D's ratio check, use only Float32 to compare

    @asinghvi17
    asinghvi17 committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    eff6180 View commit details
    Browse the repository at this point in the history

  11. Fix bad bbox method, add comments

    @asinghvi17
    asinghvi17 committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    603f706 View commit details
    Browse the repository at this point in the history

  12. Remove debug statements

    @asinghvi17
    asinghvi17 committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    25dca9a View commit details
    Browse the repository at this point in the history

  13. Update for MakieLayout module removal

    @asinghvi17
    asinghvi17 committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    4fd1d5d View commit details
    Browse the repository at this point in the history

  14. Update the lines when the camera changes.

    @asinghvi17
    asinghvi17 committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    5539a5a View commit details
    Browse the repository at this point in the history

  15. Lift on camera also

    @asinghvi17
    asinghvi17 committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    0e4292d View commit details
    Browse the repository at this point in the history

  16. Add protrusion calculation for theta ticks

    @asinghvi17
    asinghvi17 committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    1d133a1 View commit details
    Browse the repository at this point in the history

  17. Allow plot!(po::PolarAxis, ...)

    @asinghvi17
    asinghvi17 committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    0ea9644 View commit details
    Browse the repository at this point in the history

  18. Manual protrusion calc by checking text bboxes individually.

    @asinghvi17
    asinghvi17 committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    e9ba2e4 View commit details
    Browse the repository at this point in the history

  19. Implement a foundation for hacked theta-lims

    @asinghvi17
    asinghvi17 committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    227b0b5 View commit details
    Browse the repository at this point in the history

  20. Fix update_cam!(::Scene)

    @asinghvi17
    asinghvi17 committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    e662ee6 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2022

  1. Quick fix for overlooked item

    @asinghvi17
    asinghvi17 committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    aa0bb82 View commit details
    Browse the repository at this point in the history

  2. Implement text_bbox(plot::Text) 

    This reduces the amount of attribute expansions in the main code.
    @asinghvi17
    asinghvi17 committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    08d7a91 View commit details
    Browse the repository at this point in the history

  3. Implement inherit for nested theme attributes 

    This allows plots to inherit from nested attrs in the scene's theme, 
i.e., a plot can inherit `scene.Axis.yticklabelsvisible` if it exists.

This is arbitrary and robust, following the same logic (check if exists 
in current scene, if not go to parent, if not return default value) as 
the implementation for a single Symbol did.
    @asinghvi17
    asinghvi17 committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    8fb816f View commit details
    Browse the repository at this point in the history

  4. Implement title for PolarAxis

    @asinghvi17
    asinghvi17 committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    44eb5ba View commit details
    Browse the repository at this point in the history

  5. Switch default theme to inheriting from Axis

    @asinghvi17
    asinghvi17 committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    e2a3582 View commit details
    Browse the repository at this point in the history

  6. Separate r and theta minor grids in theme

    @asinghvi17
    asinghvi17 committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    3dba936 View commit details
    Browse the repository at this point in the history

  7. Update NEWS

    @asinghvi17
    asinghvi17 committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    bfc2c1d View commit details
    Browse the repository at this point in the history

  8. General cleanup

    @asinghvi17
    asinghvi17 committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    f2c90c8 View commit details
    Browse the repository at this point in the history

  9. Adjust ticks, grid and camera on scene area / limit change

    @asinghvi17
    asinghvi17 committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    60ee94a View commit details
    Browse the repository at this point in the history

  10. Change r-tick angle to avoid overlap

    @asinghvi17
    asinghvi17 committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    9432e1f View commit details
    Browse the repository at this point in the history

  11. Implement "nonlinear clip" without transparency

    @asinghvi17
    asinghvi17 committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    ae09053 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2022

  1. Address comments from code review

    @asinghvi17
    asinghvi17 committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    afbde6e View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2022

  1. Merge branch 'master' into jk/polar-axis

    @Moelf
    Moelf authored Jul 13, 2022
    Configuration menu
    Copy the full SHA
    061dabd View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2023

  1. Merge branch 'master' into jk/polar-axis

    @SimonDanisch
    SimonDanisch authored Jan 14, 2023
    Configuration menu
    Copy the full SHA
    f6b69b2 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. Merge branch 'master' into jk/polar-axis

    @SimonDanisch
    SimonDanisch authored May 17, 2023
    Configuration menu
    Copy the full SHA
    2542326 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2023

  1. fix errors

    @ffreyer
    ffreyer committed May 22, 2023
    Configuration menu
    Copy the full SHA
    190cb33 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2023

  1. prototype axis decorations in polar coords

    @ffreyer
    ffreyer committed May 29, 2023
    Configuration menu
    Copy the full SHA
    2309c09 View commit details
    Browse the repository at this point in the history

  2. move axis to overlay scene

    @ffreyer
    ffreyer committed May 29, 2023
    Configuration menu
    Copy the full SHA
    64a1654 View commit details
    Browse the repository at this point in the history

  3. rename θ to theta

    @ffreyer
    ffreyer committed May 29, 2023
    Configuration menu
    Copy the full SHA
    e3e936f View commit details
    Browse the repository at this point in the history

  4. add theta tick pad and split onany

    @ffreyer
    ffreyer committed May 29, 2023
    Configuration menu
    Copy the full SHA
    68f5462 View commit details
    Browse the repository at this point in the history

  5. get arbitrary scene areas going

    @ffreyer
    ffreyer committed May 29, 2023
    Configuration menu
    Copy the full SHA
    f8809b1 View commit details
    Browse the repository at this point in the history

  6. cleanup axis clip

    @ffreyer
    ffreyer committed May 29, 2023
    Configuration menu
    Copy the full SHA
    9a76ff5 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2023

  1. switch to two step limits, remove min radius

    @ffreyer
    ffreyer committed May 30, 2023
    Configuration menu
    Copy the full SHA
    ab168bb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into ff/jk-as-polar-axis

    @ffreyer
    ffreyer committed May 30, 2023
    Configuration menu
    Copy the full SHA
    fb3eba3 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2023

  1. discard camera changes 

    they seem to have been added elsewhere
    @ffreyer
    ffreyer committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    2340891 View commit details
    Browse the repository at this point in the history

  2. improve observable tracking/cleanup

    @ffreyer
    ffreyer committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    c42e851 View commit details
    Browse the repository at this point in the history

  3. add camera reset

    @ffreyer
    ffreyer committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    0069fc0 View commit details
    Browse the repository at this point in the history

  4. add r tick stroke

    @ffreyer
    ffreyer committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    573dde2 View commit details
    Browse the repository at this point in the history

  5. use degrees for tick labels

    @ffreyer
    ffreyer committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    651cc48 View commit details
    Browse the repository at this point in the history

  6. cleanup background color

    @ffreyer
    ffreyer committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    171af16 View commit details
    Browse the repository at this point in the history

  7. fix theta_0 handling for ticks

    @ffreyer
    ffreyer committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    23cb046 View commit details
    Browse the repository at this point in the history

  8. turn off minor grid by default

    @ffreyer
    ffreyer committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    d0425a0 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into ff/jk-as-polar-axis

    @ffreyer
    ffreyer committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    0ce66d7 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. rename Polar transform and move it

    @ffreyer
    ffreyer committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    17eb51a View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2023

  1. Merge branch 'master' into ff/jk-as-polar-axis

    @SimonDanisch
    SimonDanisch authored Jul 4, 2023
    Configuration menu
    Copy the full SHA
    88e5856 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. Merge branch 'master' into ff/jk-as-polar-axis

    @SimonDanisch
    SimonDanisch authored Jul 14, 2023
    Configuration menu
    Copy the full SHA
    5f023f4 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2023

  1. temp fix for poly transforms

    @ffreyer
    ffreyer committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    cc02239 View commit details
    Browse the repository at this point in the history

  2. cleanup background color handling

    @ffreyer
    ffreyer committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    dcd01f1 View commit details
    Browse the repository at this point in the history

  3. cleanup protrusions

    @ffreyer
    ffreyer committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    7f379c1 View commit details
    Browse the repository at this point in the history

  4. cleanup title position

    @ffreyer
    ffreyer committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    c7e86af View commit details
    Browse the repository at this point in the history

  5. remove default outline on r tick labels

    @ffreyer
    ffreyer committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    d9620a9 View commit details
    Browse the repository at this point in the history

  6. general cleanup

    @ffreyer
    ffreyer committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    2e03171 View commit details
    Browse the repository at this point in the history

  7. add docs

    @ffreyer
    ffreyer committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    17b7208 View commit details
    Browse the repository at this point in the history

  8. add refimg tests

    @ffreyer
    ffreyer committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    ea6d168 View commit details
    Browse the repository at this point in the history

  9. add polar transform test & fix inverse

    @ffreyer
    ffreyer committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    dd1ac4d View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. fix duplicate NEWS entry

    @ffreyer
    ffreyer committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    884656e View commit details
    Browse the repository at this point in the history

  2. add outlines for theta ticks

    @ffreyer
    ffreyer committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    ecd8e06 View commit details
    Browse the repository at this point in the history

  3. add cycler support to PolarAxis

    @SimonDanisch
    SimonDanisch committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    c856680 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into ff/jk-as-polar-axis

    @SimonDanisch
    SimonDanisch authored Jul 17, 2023
    Configuration menu
    Copy the full SHA
    52b13fa View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. inherit background color

    @ffreyer
    ffreyer committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    43532ee View commit details
    Browse the repository at this point in the history

  2. add attrdocs

    @ffreyer
    ffreyer authored Jul 18, 2023
    Configuration menu
    Copy the full SHA
    45ecfb6 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into ff/jk-as-polar-axis

    @SimonDanisch
    SimonDanisch authored Jul 18, 2023
    Configuration menu
    Copy the full SHA
    59bbb79 View commit details
    Browse the repository at this point in the history