-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continuation of polar axis #2990
Conversation
The theme should be mostly set, grids exist but ticks need to be plotted.
This reduces the amount of attribute expansions in the main code.
This allows plots to inherit from nested attrs in the scene's theme, i.e., a plot can inherit `scene.Axis.yticklabelsvisible` if it exists. This is arbitrary and robust, following the same logic (check if exists in current scene, if not go to parent, if not return default value) as the implementation for a single Symbol did.
Missing reference imagesFound 3 new images without existing references. |
Missing reference imagesFound 3 new images without existing references. |
src/makielayout/blocks/polaraxis.jl
Outdated
|
||
allattrs = merge(attributes, Attributes(kw_attributes)) | ||
|
||
# cycle = get_cycle_for_plottype(allattrs, P) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah guess we should try to add those back?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I added cycler support, so I think this is good to go!
Missing reference imagesFound 3 new images without existing references. |
Other than that, so far I think it looks pretty great! |
I think we can leave that for later ... |
Yes, that sounds good, a polar axis could then be added to the example plot https://docs.makie.org/stable/documentation/theming/predefined_themes/ |
Ah actually I think the spine color of |
Description
Continuation of #2014
I rewrote the axis decorations to use a polar transformedscene to avoid most of the explicit polar space -> pixel space transformation. I'm not sure if this is something we want in the end so I'm using my own branch for this.
TODO:
maybe move code to a camera controlleron(f, scene, obs...)
)PolarAxisTransform
toPolar
and move it to transformation.jlReminders on cleanup/visual improvements:
Type of change
Checklist