-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Camera3D Improvements #2746
Closed
Camera3D Improvements #2746
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
066f0b7
switch back to translation zoom, cleanup/reorganize
ffreyer e4b056a
fix typo
ffreyer 6cbca9e
add example
ffreyer b54c0ae
remove enable translation/rotation/zoom
ffreyer 3e07289
update test values
ffreyer 11313dc
cleanup docstring
ffreyer 4de5fa3
switch back rotation order to avoid change in upvector
ffreyer ae7f89a
fix docstring [skip ci]
ffreyer d31d905
update docs
ffreyer 8185a96
update tests
ffreyer 3c22c47
fix zoom and switch back to more extreme near/far
ffreyer 6786f96
tweak default zoom some more
ffreyer 5274295
Add update_cam! with angles
ffreyer 4fee98b
Merge branch 'master' into ff/camera
ffreyer c890d34
update NEWS
ffreyer d6639fc
bring back perspective zoom_shift_lookat
ffreyer becc8cd
add center in orbital update_cam!
ffreyer f264360
bring back fov controls
ffreyer 87e7254
deprecate old_cam [skip ci]
ffreyer 6594406
fix whitespace?
ffreyer ed48aa6
Merge branch 'master' into ff/camera
ffreyer 43e6428
cleanup news
ffreyer a72abbd
Merge branch 'master' into ff/camera
SimonDanisch 78ee1e5
improve default controls/hotkeys
ffreyer a7e819b
add on-click refocus of camera
ffreyer d51ed11
DataInspector fixes
ffreyer fdc3666
fix wrong tooltip in volumeslices
ffreyer 6945b97
fix line indicator in band
ffreyer 1053b3a
update NEWS
ffreyer 10aff36
update docs
ffreyer 6972303
Merge branch 'master' into ff/camera
SimonDanisch 64f7730
consider transforms when centering on plot object
ffreyer fd9a04d
Merge branch 'master' into ff/camera
ffreyer fc4fcd5
fix type error in cam2d!
ffreyer a26e6a1
check other ray_at_cursor methods
ffreyer 381eb82
Merge branch 'master' into ff/camera
ffreyer d89aac0
Merge branch 'master' into ff/camera
ffreyer 001542e
avoid centering on unrelated plots
ffreyer 34e9072
Merge branch 'master' into ff/camera
ffreyer 98c1096
fix test errors
ffreyer 01b1589
Merge branch 'master' into ff/camera
ffreyer 12bcc1c
Merge branch 'master' into ff/camera
SimonDanisch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hard coded the camera setup here (and below) to avoid test errors. I don't know if we want to keep this or update refimgs so I'm pointing it out. The difference is tiny.