-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Camera3D Improvements #2746
Camera3D Improvements #2746
Conversation
can be achieved by removing hotkeys
Compile Times benchmarkNote, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running: using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
|
It would be good to get some feedback on how these changes feel or if there's anything else worth adding to make the 3D camera feel better. For example I think that for orthographic cameras things are disappearing too quickly. |
Refimg tests all look fine. The differences should all just be minor changes in the zoom level from |
At default fov the only major difference between I think Regarding tests - there are some small differences in the default zoom level I believe, which only GLMakie tests catch. So nothing to worry about. |
I just tried this on mac with touchpad, felt pretty good overall but some speeds definitely needed adjusting for trackpad. Rotations were way to fast, and zoom was way too slow. What worked for me was: cam = cameracontrols(ax.scene)
cam.settings.mouse_rotationspeed[] = 0.5
cam.settings.mouse_zoomspeed[] = 2 which made things a lot more responsive. |
Touchpad Windows: I agree, your defaults feel better It seems like mouse speed is roughly 1:2 between windows and linux for me - matching that 0.5 factor. With a For zooming I think it's very dependent on trackpad vs mouse, which we can't really tell apart 🙁 |
Alright I went through and tested DataInspector. I fixed a bunch of small issues which were probably unrelated. The errors in GLMakie are related to minor changes in the default camera position/zoom. The GLMakie specific tests have higher precision and notice this, the normal refiimages do not. I adjusted the camera interaction tests in Makie with new numbers so that those don't fail. I still need to make a few tweaks to documentation. After that this will be ready to merge again. |
@@ -65,6 +65,7 @@ end | |||
markersize=size, | |||
axis = (; scenekw = (;limits=Rect3f(Point3(0), Point3(1)))) | |||
) | |||
update_cam!(ax.scene, Point3f(2.224431, 2.224431, 2.128731), Point3f(0.5957, 0.5957, 0.50000006)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hard coded the camera setup here (and below) to avoid test errors. I don't know if we want to keep this or update refimgs so I'm pointing it out. The difference is tiny.
Missing reference imagesFound 1 new images without existing references. |
commit 12bcc1c Merge: 01b1589 f3bb1c8 Author: Simon <[email protected]> Date: Tue Aug 1 11:03:08 2023 +0200 Merge branch 'master' into ff/camera commit 01b1589 Merge: 98c1096 07496e9 Author: ffreyer <[email protected]> Date: Wed Jul 12 18:07:07 2023 +0200 Merge branch 'master' into ff/camera commit 98c1096 Author: ffreyer <[email protected]> Date: Tue Jul 4 21:26:00 2023 +0200 fix test errors commit 34e9072 Merge: 001542e eaf1028 Author: Frederic Freyer <[email protected]> Date: Tue Jul 4 18:46:07 2023 +0200 Merge branch 'master' into ff/camera commit 001542e Author: ffreyer <[email protected]> Date: Tue Jul 4 18:25:09 2023 +0200 avoid centering on unrelated plots commit d89aac0 Author: ffreyer <[email protected]> Date: Tue Jul 4 18:24:22 2023 +0200 Merge branch 'master' into ff/camera commit 381eb82 Merge: a26e6a1 8ccb6bd Author: Frederic Freyer <[email protected]> Date: Thu Jun 22 14:31:02 2023 +0200 Merge branch 'master' into ff/camera commit a26e6a1 Author: ffreyer <[email protected]> Date: Mon Jun 12 13:45:21 2023 +0200 check other ray_at_cursor methods commit fc4fcd5 Author: ffreyer <[email protected]> Date: Mon Jun 12 13:45:01 2023 +0200 fix type error in cam2d! commit fd9a04d Merge: 64f7730 5f96457 Author: ffreyer <[email protected]> Date: Mon Jun 12 13:19:06 2023 +0200 Merge branch 'master' into ff/camera commit 64f7730 Author: ffreyer <[email protected]> Date: Fri May 5 15:32:02 2023 +0200 consider transforms when centering on plot object commit 6972303 Merge: 10aff36 13e1d84 Author: Simon <[email protected]> Date: Tue Apr 25 16:03:43 2023 +0200 Merge branch 'master' into ff/camera commit 10aff36 Author: ffreyer <[email protected]> Date: Sun Apr 23 21:10:30 2023 +0200 update docs commit 1053b3a Author: ffreyer <[email protected]> Date: Sun Apr 23 18:47:33 2023 +0200 update NEWS commit 6945b97 Author: ffreyer <[email protected]> Date: Sun Apr 23 18:23:42 2023 +0200 fix line indicator in band commit fdc3666 Author: ffreyer <[email protected]> Date: Sun Apr 23 13:27:07 2023 +0200 fix wrong tooltip in volumeslices commit d51ed11 Author: ffreyer <[email protected]> Date: Sun Apr 23 10:45:40 2023 +0200 DataInspector fixes - fix error on range access for lines - fix a typo - fix blinking in image - fix error in arrows commit a7e819b Author: ffreyer <[email protected]> Date: Sat Apr 22 00:54:00 2023 +0200 add on-click refocus of camera commit 78ee1e5 Author: ffreyer <[email protected]> Date: Wed Apr 19 21:52:04 2023 +0200 improve default controls/hotkeys commit a72abbd Merge: 43e6428 bc13edb Author: Simon <[email protected]> Date: Wed Apr 19 14:30:27 2023 +0200 Merge branch 'master' into ff/camera commit 43e6428 Author: ffreyer <[email protected]> Date: Tue Mar 28 17:21:09 2023 +0200 cleanup news commit ed48aa6 Merge: 6594406 cdad6dd Author: ffreyer <[email protected]> Date: Tue Mar 28 17:20:34 2023 +0200 Merge branch 'master' into ff/camera commit 6594406 Author: ffreyer <[email protected]> Date: Tue Mar 28 17:20:28 2023 +0200 fix whitespace? commit 87e7254 Author: ffreyer <[email protected]> Date: Sun Mar 19 16:28:45 2023 +0100 deprecate old_cam [skip ci] commit f264360 Author: ffreyer <[email protected]> Date: Sun Mar 19 16:04:24 2023 +0100 bring back fov controls commit becc8cd Author: ffreyer <[email protected]> Date: Sun Mar 19 15:49:28 2023 +0100 add center in orbital update_cam! commit d6639fc Author: ffreyer <[email protected]> Date: Sun Mar 19 15:28:48 2023 +0100 bring back perspective zoom_shift_lookat commit c890d34 Author: ffreyer <[email protected]> Date: Sun Mar 19 15:09:00 2023 +0100 update NEWS commit 4fee98b Merge: 5274295 4bebd86 Author: ffreyer <[email protected]> Date: Sun Mar 19 15:00:39 2023 +0100 Merge branch 'master' into ff/camera commit 5274295 Author: ffreyer <[email protected]> Date: Thu Mar 16 18:46:30 2023 +0100 Add update_cam! with angles commit 6786f96 Author: ffreyer <[email protected]> Date: Wed Mar 15 17:53:18 2023 +0100 tweak default zoom some more commit 3c22c47 Author: ffreyer <[email protected]> Date: Wed Mar 15 15:41:27 2023 +0100 fix zoom and switch back to more extreme near/far commit 8185a96 Author: ffreyer <[email protected]> Date: Mon Mar 13 01:09:17 2023 +0100 update tests commit d31d905 Author: ffreyer <[email protected]> Date: Mon Mar 13 00:56:41 2023 +0100 update docs commit ae7f89a Author: ffreyer <[email protected]> Date: Mon Mar 13 00:34:04 2023 +0100 fix docstring [skip ci] commit 4de5fa3 Author: ffreyer <[email protected]> Date: Mon Mar 13 00:15:11 2023 +0100 switch back rotation order to avoid change in upvector commit 11313dc Author: ffreyer <[email protected]> Date: Mon Mar 13 00:03:05 2023 +0100 cleanup docstring commit 3e07289 Author: ffreyer <[email protected]> Date: Sun Mar 12 23:37:22 2023 +0100 update test values commit b54c0ae Author: ffreyer <[email protected]> Date: Sun Mar 12 20:00:54 2023 +0100 remove enable translation/rotation/zoom can be achieved by removing hotkeys commit 6cbca9e Author: ffreyer <[email protected]> Date: Sun Mar 12 19:55:32 2023 +0100 add example commit e4b056a Author: ffreyer <[email protected]> Date: Sun Mar 12 19:46:57 2023 +0100 fix typo commit 066f0b7 Author: ffreyer <[email protected]> Date: Sun Mar 12 19:23:35 2023 +0100 switch back to translation zoom, cleanup/reorganize
commit 12bcc1c Merge: 01b1589 f3bb1c8 Author: Simon <[email protected]> Date: Tue Aug 1 11:03:08 2023 +0200 Merge branch 'master' into ff/camera commit 01b1589 Merge: 98c1096 07496e9 Author: ffreyer <[email protected]> Date: Wed Jul 12 18:07:07 2023 +0200 Merge branch 'master' into ff/camera commit 98c1096 Author: ffreyer <[email protected]> Date: Tue Jul 4 21:26:00 2023 +0200 fix test errors commit 34e9072 Merge: 001542e eaf1028 Author: Frederic Freyer <[email protected]> Date: Tue Jul 4 18:46:07 2023 +0200 Merge branch 'master' into ff/camera commit 001542e Author: ffreyer <[email protected]> Date: Tue Jul 4 18:25:09 2023 +0200 avoid centering on unrelated plots commit d89aac0 Author: ffreyer <[email protected]> Date: Tue Jul 4 18:24:22 2023 +0200 Merge branch 'master' into ff/camera commit 381eb82 Merge: a26e6a1 8ccb6bd Author: Frederic Freyer <[email protected]> Date: Thu Jun 22 14:31:02 2023 +0200 Merge branch 'master' into ff/camera commit a26e6a1 Author: ffreyer <[email protected]> Date: Mon Jun 12 13:45:21 2023 +0200 check other ray_at_cursor methods commit fc4fcd5 Author: ffreyer <[email protected]> Date: Mon Jun 12 13:45:01 2023 +0200 fix type error in cam2d! commit fd9a04d Merge: 64f7730 5f96457 Author: ffreyer <[email protected]> Date: Mon Jun 12 13:19:06 2023 +0200 Merge branch 'master' into ff/camera commit 64f7730 Author: ffreyer <[email protected]> Date: Fri May 5 15:32:02 2023 +0200 consider transforms when centering on plot object commit 6972303 Merge: 10aff36 13e1d84 Author: Simon <[email protected]> Date: Tue Apr 25 16:03:43 2023 +0200 Merge branch 'master' into ff/camera commit 10aff36 Author: ffreyer <[email protected]> Date: Sun Apr 23 21:10:30 2023 +0200 update docs commit 1053b3a Author: ffreyer <[email protected]> Date: Sun Apr 23 18:47:33 2023 +0200 update NEWS commit 6945b97 Author: ffreyer <[email protected]> Date: Sun Apr 23 18:23:42 2023 +0200 fix line indicator in band commit fdc3666 Author: ffreyer <[email protected]> Date: Sun Apr 23 13:27:07 2023 +0200 fix wrong tooltip in volumeslices commit d51ed11 Author: ffreyer <[email protected]> Date: Sun Apr 23 10:45:40 2023 +0200 DataInspector fixes - fix error on range access for lines - fix a typo - fix blinking in image - fix error in arrows commit a7e819b Author: ffreyer <[email protected]> Date: Sat Apr 22 00:54:00 2023 +0200 add on-click refocus of camera commit 78ee1e5 Author: ffreyer <[email protected]> Date: Wed Apr 19 21:52:04 2023 +0200 improve default controls/hotkeys commit a72abbd Merge: 43e6428 bc13edb Author: Simon <[email protected]> Date: Wed Apr 19 14:30:27 2023 +0200 Merge branch 'master' into ff/camera commit 43e6428 Author: ffreyer <[email protected]> Date: Tue Mar 28 17:21:09 2023 +0200 cleanup news commit ed48aa6 Merge: 6594406 cdad6dd Author: ffreyer <[email protected]> Date: Tue Mar 28 17:20:34 2023 +0200 Merge branch 'master' into ff/camera commit 6594406 Author: ffreyer <[email protected]> Date: Tue Mar 28 17:20:28 2023 +0200 fix whitespace? commit 87e7254 Author: ffreyer <[email protected]> Date: Sun Mar 19 16:28:45 2023 +0100 deprecate old_cam [skip ci] commit f264360 Author: ffreyer <[email protected]> Date: Sun Mar 19 16:04:24 2023 +0100 bring back fov controls commit becc8cd Author: ffreyer <[email protected]> Date: Sun Mar 19 15:49:28 2023 +0100 add center in orbital update_cam! commit d6639fc Author: ffreyer <[email protected]> Date: Sun Mar 19 15:28:48 2023 +0100 bring back perspective zoom_shift_lookat commit c890d34 Author: ffreyer <[email protected]> Date: Sun Mar 19 15:09:00 2023 +0100 update NEWS commit 4fee98b Merge: 5274295 4bebd86 Author: ffreyer <[email protected]> Date: Sun Mar 19 15:00:39 2023 +0100 Merge branch 'master' into ff/camera commit 5274295 Author: ffreyer <[email protected]> Date: Thu Mar 16 18:46:30 2023 +0100 Add update_cam! with angles commit 6786f96 Author: ffreyer <[email protected]> Date: Wed Mar 15 17:53:18 2023 +0100 tweak default zoom some more commit 3c22c47 Author: ffreyer <[email protected]> Date: Wed Mar 15 15:41:27 2023 +0100 fix zoom and switch back to more extreme near/far commit 8185a96 Author: ffreyer <[email protected]> Date: Mon Mar 13 01:09:17 2023 +0100 update tests commit d31d905 Author: ffreyer <[email protected]> Date: Mon Mar 13 00:56:41 2023 +0100 update docs commit ae7f89a Author: ffreyer <[email protected]> Date: Mon Mar 13 00:34:04 2023 +0100 fix docstring [skip ci] commit 4de5fa3 Author: ffreyer <[email protected]> Date: Mon Mar 13 00:15:11 2023 +0100 switch back rotation order to avoid change in upvector commit 11313dc Author: ffreyer <[email protected]> Date: Mon Mar 13 00:03:05 2023 +0100 cleanup docstring commit 3e07289 Author: ffreyer <[email protected]> Date: Sun Mar 12 23:37:22 2023 +0100 update test values commit b54c0ae Author: ffreyer <[email protected]> Date: Sun Mar 12 20:00:54 2023 +0100 remove enable translation/rotation/zoom can be achieved by removing hotkeys commit 6cbca9e Author: ffreyer <[email protected]> Date: Sun Mar 12 19:55:32 2023 +0100 add example commit e4b056a Author: ffreyer <[email protected]> Date: Sun Mar 12 19:46:57 2023 +0100 fix typo commit 066f0b7 Author: ffreyer <[email protected]> Date: Sun Mar 12 19:23:35 2023 +0100 switch back to translation zoom, cleanup/reorganize
commit 12bcc1c Merge: 01b1589 f3bb1c8 Author: Simon <[email protected]> Date: Tue Aug 1 11:03:08 2023 +0200 Merge branch 'master' into ff/camera commit 01b1589 Merge: 98c1096 07496e9 Author: ffreyer <[email protected]> Date: Wed Jul 12 18:07:07 2023 +0200 Merge branch 'master' into ff/camera commit 98c1096 Author: ffreyer <[email protected]> Date: Tue Jul 4 21:26:00 2023 +0200 fix test errors commit 34e9072 Merge: 001542e eaf1028 Author: Frederic Freyer <[email protected]> Date: Tue Jul 4 18:46:07 2023 +0200 Merge branch 'master' into ff/camera commit 001542e Author: ffreyer <[email protected]> Date: Tue Jul 4 18:25:09 2023 +0200 avoid centering on unrelated plots commit d89aac0 Author: ffreyer <[email protected]> Date: Tue Jul 4 18:24:22 2023 +0200 Merge branch 'master' into ff/camera commit 381eb82 Merge: a26e6a1 8ccb6bd Author: Frederic Freyer <[email protected]> Date: Thu Jun 22 14:31:02 2023 +0200 Merge branch 'master' into ff/camera commit a26e6a1 Author: ffreyer <[email protected]> Date: Mon Jun 12 13:45:21 2023 +0200 check other ray_at_cursor methods commit fc4fcd5 Author: ffreyer <[email protected]> Date: Mon Jun 12 13:45:01 2023 +0200 fix type error in cam2d! commit fd9a04d Merge: 64f7730 5f96457 Author: ffreyer <[email protected]> Date: Mon Jun 12 13:19:06 2023 +0200 Merge branch 'master' into ff/camera commit 64f7730 Author: ffreyer <[email protected]> Date: Fri May 5 15:32:02 2023 +0200 consider transforms when centering on plot object commit 6972303 Merge: 10aff36 13e1d84 Author: Simon <[email protected]> Date: Tue Apr 25 16:03:43 2023 +0200 Merge branch 'master' into ff/camera commit 10aff36 Author: ffreyer <[email protected]> Date: Sun Apr 23 21:10:30 2023 +0200 update docs commit 1053b3a Author: ffreyer <[email protected]> Date: Sun Apr 23 18:47:33 2023 +0200 update NEWS commit 6945b97 Author: ffreyer <[email protected]> Date: Sun Apr 23 18:23:42 2023 +0200 fix line indicator in band commit fdc3666 Author: ffreyer <[email protected]> Date: Sun Apr 23 13:27:07 2023 +0200 fix wrong tooltip in volumeslices commit d51ed11 Author: ffreyer <[email protected]> Date: Sun Apr 23 10:45:40 2023 +0200 DataInspector fixes - fix error on range access for lines - fix a typo - fix blinking in image - fix error in arrows commit a7e819b Author: ffreyer <[email protected]> Date: Sat Apr 22 00:54:00 2023 +0200 add on-click refocus of camera commit 78ee1e5 Author: ffreyer <[email protected]> Date: Wed Apr 19 21:52:04 2023 +0200 improve default controls/hotkeys commit a72abbd Merge: 43e6428 bc13edb Author: Simon <[email protected]> Date: Wed Apr 19 14:30:27 2023 +0200 Merge branch 'master' into ff/camera commit 43e6428 Author: ffreyer <[email protected]> Date: Tue Mar 28 17:21:09 2023 +0200 cleanup news commit ed48aa6 Merge: 6594406 cdad6dd Author: ffreyer <[email protected]> Date: Tue Mar 28 17:20:34 2023 +0200 Merge branch 'master' into ff/camera commit 6594406 Author: ffreyer <[email protected]> Date: Tue Mar 28 17:20:28 2023 +0200 fix whitespace? commit 87e7254 Author: ffreyer <[email protected]> Date: Sun Mar 19 16:28:45 2023 +0100 deprecate old_cam [skip ci] commit f264360 Author: ffreyer <[email protected]> Date: Sun Mar 19 16:04:24 2023 +0100 bring back fov controls commit becc8cd Author: ffreyer <[email protected]> Date: Sun Mar 19 15:49:28 2023 +0100 add center in orbital update_cam! commit d6639fc Author: ffreyer <[email protected]> Date: Sun Mar 19 15:28:48 2023 +0100 bring back perspective zoom_shift_lookat commit c890d34 Author: ffreyer <[email protected]> Date: Sun Mar 19 15:09:00 2023 +0100 update NEWS commit 4fee98b Merge: 5274295 4bebd86 Author: ffreyer <[email protected]> Date: Sun Mar 19 15:00:39 2023 +0100 Merge branch 'master' into ff/camera commit 5274295 Author: ffreyer <[email protected]> Date: Thu Mar 16 18:46:30 2023 +0100 Add update_cam! with angles commit 6786f96 Author: ffreyer <[email protected]> Date: Wed Mar 15 17:53:18 2023 +0100 tweak default zoom some more commit 3c22c47 Author: ffreyer <[email protected]> Date: Wed Mar 15 15:41:27 2023 +0100 fix zoom and switch back to more extreme near/far commit 8185a96 Author: ffreyer <[email protected]> Date: Mon Mar 13 01:09:17 2023 +0100 update tests commit d31d905 Author: ffreyer <[email protected]> Date: Mon Mar 13 00:56:41 2023 +0100 update docs commit ae7f89a Author: ffreyer <[email protected]> Date: Mon Mar 13 00:34:04 2023 +0100 fix docstring [skip ci] commit 4de5fa3 Author: ffreyer <[email protected]> Date: Mon Mar 13 00:15:11 2023 +0100 switch back rotation order to avoid change in upvector commit 11313dc Author: ffreyer <[email protected]> Date: Mon Mar 13 00:03:05 2023 +0100 cleanup docstring commit 3e07289 Author: ffreyer <[email protected]> Date: Sun Mar 12 23:37:22 2023 +0100 update test values commit b54c0ae Author: ffreyer <[email protected]> Date: Sun Mar 12 20:00:54 2023 +0100 remove enable translation/rotation/zoom can be achieved by removing hotkeys commit 6cbca9e Author: ffreyer <[email protected]> Date: Sun Mar 12 19:55:32 2023 +0100 add example commit e4b056a Author: ffreyer <[email protected]> Date: Sun Mar 12 19:46:57 2023 +0100 fix typo commit 066f0b7 Author: ffreyer <[email protected]> Date: Sun Mar 12 19:23:35 2023 +0100 switch back to translation zoom, cleanup/reorganize
commit 12bcc1c Merge: 01b1589 f3bb1c8 Author: Simon <[email protected]> Date: Tue Aug 1 11:03:08 2023 +0200 Merge branch 'master' into ff/camera commit 01b1589 Merge: 98c1096 07496e9 Author: ffreyer <[email protected]> Date: Wed Jul 12 18:07:07 2023 +0200 Merge branch 'master' into ff/camera commit 98c1096 Author: ffreyer <[email protected]> Date: Tue Jul 4 21:26:00 2023 +0200 fix test errors commit 34e9072 Merge: 001542e eaf1028 Author: Frederic Freyer <[email protected]> Date: Tue Jul 4 18:46:07 2023 +0200 Merge branch 'master' into ff/camera commit 001542e Author: ffreyer <[email protected]> Date: Tue Jul 4 18:25:09 2023 +0200 avoid centering on unrelated plots commit d89aac0 Author: ffreyer <[email protected]> Date: Tue Jul 4 18:24:22 2023 +0200 Merge branch 'master' into ff/camera commit 381eb82 Merge: a26e6a1 8ccb6bd Author: Frederic Freyer <[email protected]> Date: Thu Jun 22 14:31:02 2023 +0200 Merge branch 'master' into ff/camera commit a26e6a1 Author: ffreyer <[email protected]> Date: Mon Jun 12 13:45:21 2023 +0200 check other ray_at_cursor methods commit fc4fcd5 Author: ffreyer <[email protected]> Date: Mon Jun 12 13:45:01 2023 +0200 fix type error in cam2d! commit fd9a04d Merge: 64f7730 5f96457 Author: ffreyer <[email protected]> Date: Mon Jun 12 13:19:06 2023 +0200 Merge branch 'master' into ff/camera commit 64f7730 Author: ffreyer <[email protected]> Date: Fri May 5 15:32:02 2023 +0200 consider transforms when centering on plot object commit 6972303 Merge: 10aff36 13e1d84 Author: Simon <[email protected]> Date: Tue Apr 25 16:03:43 2023 +0200 Merge branch 'master' into ff/camera commit 10aff36 Author: ffreyer <[email protected]> Date: Sun Apr 23 21:10:30 2023 +0200 update docs commit 1053b3a Author: ffreyer <[email protected]> Date: Sun Apr 23 18:47:33 2023 +0200 update NEWS commit 6945b97 Author: ffreyer <[email protected]> Date: Sun Apr 23 18:23:42 2023 +0200 fix line indicator in band commit fdc3666 Author: ffreyer <[email protected]> Date: Sun Apr 23 13:27:07 2023 +0200 fix wrong tooltip in volumeslices commit d51ed11 Author: ffreyer <[email protected]> Date: Sun Apr 23 10:45:40 2023 +0200 DataInspector fixes - fix error on range access for lines - fix a typo - fix blinking in image - fix error in arrows commit a7e819b Author: ffreyer <[email protected]> Date: Sat Apr 22 00:54:00 2023 +0200 add on-click refocus of camera commit 78ee1e5 Author: ffreyer <[email protected]> Date: Wed Apr 19 21:52:04 2023 +0200 improve default controls/hotkeys commit a72abbd Merge: 43e6428 bc13edb Author: Simon <[email protected]> Date: Wed Apr 19 14:30:27 2023 +0200 Merge branch 'master' into ff/camera commit 43e6428 Author: ffreyer <[email protected]> Date: Tue Mar 28 17:21:09 2023 +0200 cleanup news commit ed48aa6 Merge: 6594406 cdad6dd Author: ffreyer <[email protected]> Date: Tue Mar 28 17:20:34 2023 +0200 Merge branch 'master' into ff/camera commit 6594406 Author: ffreyer <[email protected]> Date: Tue Mar 28 17:20:28 2023 +0200 fix whitespace? commit 87e7254 Author: ffreyer <[email protected]> Date: Sun Mar 19 16:28:45 2023 +0100 deprecate old_cam [skip ci] commit f264360 Author: ffreyer <[email protected]> Date: Sun Mar 19 16:04:24 2023 +0100 bring back fov controls commit becc8cd Author: ffreyer <[email protected]> Date: Sun Mar 19 15:49:28 2023 +0100 add center in orbital update_cam! commit d6639fc Author: ffreyer <[email protected]> Date: Sun Mar 19 15:28:48 2023 +0100 bring back perspective zoom_shift_lookat commit c890d34 Author: ffreyer <[email protected]> Date: Sun Mar 19 15:09:00 2023 +0100 update NEWS commit 4fee98b Merge: 5274295 4bebd86 Author: ffreyer <[email protected]> Date: Sun Mar 19 15:00:39 2023 +0100 Merge branch 'master' into ff/camera commit 5274295 Author: ffreyer <[email protected]> Date: Thu Mar 16 18:46:30 2023 +0100 Add update_cam! with angles commit 6786f96 Author: ffreyer <[email protected]> Date: Wed Mar 15 17:53:18 2023 +0100 tweak default zoom some more commit 3c22c47 Author: ffreyer <[email protected]> Date: Wed Mar 15 15:41:27 2023 +0100 fix zoom and switch back to more extreme near/far commit 8185a96 Author: ffreyer <[email protected]> Date: Mon Mar 13 01:09:17 2023 +0100 update tests commit d31d905 Author: ffreyer <[email protected]> Date: Mon Mar 13 00:56:41 2023 +0100 update docs commit ae7f89a Author: ffreyer <[email protected]> Date: Mon Mar 13 00:34:04 2023 +0100 fix docstring [skip ci] commit 4de5fa3 Author: ffreyer <[email protected]> Date: Mon Mar 13 00:15:11 2023 +0100 switch back rotation order to avoid change in upvector commit 11313dc Author: ffreyer <[email protected]> Date: Mon Mar 13 00:03:05 2023 +0100 cleanup docstring commit 3e07289 Author: ffreyer <[email protected]> Date: Sun Mar 12 23:37:22 2023 +0100 update test values commit b54c0ae Author: ffreyer <[email protected]> Date: Sun Mar 12 20:00:54 2023 +0100 remove enable translation/rotation/zoom can be achieved by removing hotkeys commit 6cbca9e Author: ffreyer <[email protected]> Date: Sun Mar 12 19:55:32 2023 +0100 add example commit e4b056a Author: ffreyer <[email protected]> Date: Sun Mar 12 19:46:57 2023 +0100 fix typo commit 066f0b7 Author: ffreyer <[email protected]> Date: Sun Mar 12 19:23:35 2023 +0100 switch back to translation zoom, cleanup/reorganize
I'm closing this since it's part of the beta branch now |
Continues #2831 ! Still needs to check, if I rebased correctly and didn't incorrectly apply some of the changes! ## Merged PRs - #2598 - #2746 - #2346 - #2544 - #3082 - #2868 - #3062 - #3106 - #3281 - #3246 ## TODOS - [x] fix flaky test `@test GLMakie.window_size(screen.glscreen) == scaled(screen, (W, H))` - [x] Merge axis type inferences from #2220 - [x] Test on different resolution screens, IJulia, Pluto, VSCode, Windowed - [x] rebase to only have merge commits from the PRs - [x] investigate unexpected speed ups - [x] reset camera settings from tests - [ ] check doc image generation - [x] rethink default near/far in Camera3D (compatability with OIT) - [x] merge #3246 - [x] fix WGLMakie issues/tests: - [x] fix line depth issues (see tests: ~~hexbin colorrange~~ (not new), LaTeXStrings in Axis3, Axis3 axis reversal) - [x] fix lighting of surface with nan points (fixed in #3246) - ~~volume/3D contour artifacts (see 3D Contour with 2D contour slices)~~ not new - ~~artifacting in "colorscale (lines)"~~ not new - [x] GLMakie: - [x] slight outline in "scatter image markers" test - ~~clipping/z-fighting in "volume translated"~~ not new - [x] CairoMakie: - ~~Artfiacting in `colorscale (lines)"~~ not new - ~~markersize in "scatter rotations" changed?~~ not new - ~~color change in "colorscale (poly)"~~ not new - ~~transparency/render order of "OldAxis + Surface"~~ not new - ~~render order in "Merged color mesh"~~ not new - ~~render order of "Surface + wireframe + contour"~~ not new - [x] Check "SpecApi in convert_arguments" (colors swapped?) ## Fixes the following errors - fixes #2721 via #2746 - fixes #1600 via #2746 - fixes #1236 via #2746 - fixes MakieOrg/GeoMakie.jl#133 via #2598 - closes #2522 - closes #3239 via #3246 - fixes #3238 via #3246 - fixes #2985 via #3246 - fixes #3307 via #3281
Description
Some general camera improvements/changes
Breaking
Camera3D
now uses the same zoom style asold_cam3d!
again, i.e. translatingeyeposition
.norm(eyeposition - lookat)
, i.e. the zoom level.cam.controls
for hotkeys andcam.settings
for everything elseNon-breaking
norm(eyeposition - lookat)
, i.e. zoom levelold_cam3d!
etc.Camera3D
can now reproduce this, though not exactly due to QoL tweaks.Fixes #2721, #1600, #1236 (y/z swap, documentation)
DataInspector fixes
I moved a bunch of code around that's also used by
DataInspector
so I did some testing and fixing on that too. Most of these fixes are probably not related to this pr.getindex_sv(::Range, idx)
image
inspectionType of change
Breaking change
Checklist
ispressed