move attribute to be common to all semantic attributes #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* forward declare DynamicSceneGraph where possible * rework NodeSymbol and hide eigen in new file * forward declare node attributes and some bounding boxes * forward declare mesh for bounding box * forward declare edge attributes and remove graph utilities from layer * split bindings into separate files * push edges towards derived layers * (wip) move traits and status * split layer prefix from types * minor cleanup of node * simplify eraseVertices * drop getPosition and eigen dep * drop node symbol include * remove typedef from * add missing bindings and fix compilation * add binary serialization for python layers * fix pytorch tests * remove commented code --------- Co-authored-by: Nathan Hughes <[email protected]>
* try adding python workflow * add test deps * install torch cpu only * fix url typo * add python badge --------- Co-authored-by: Nathan Hughes <[email protected]>
nathanhhughes
force-pushed
the
feature/move_label_confidence
branch
from
81095d0
to
4dbf0a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussion with Jared, I think this makes more sense to live in
SemanticNodeAttributesthanRoomNodeAttributes. Plan is to hold off on merging until everyone using the label likelihoods has adapted to the change (which does not seem that urgent)