Fix Hotkey Modifiers on X11 #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out that X11 is very strict about the hotkey modifiers. They need to match exactly, otherwise the hotkey is not recognized. The problem is that there's various "lock" modifiers, such as the caps lock, num lock, and scroll lock, that are always considered for this, but are not really keys that you explicitly press and instead are active or inactive until you toggle them. And they need to match exactly as well. Whoever thought that's a good design should stop doing so immediately.
CryZe
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that X11 is very strict about the hotkey modifiers. They need to match exactly, otherwise the hotkey is not recognized. The problem is that there's various "lock" modifiers, such as the caps lock, num lock, and scroll lock, that are always considered for this, but are not really keys that you explicitly press and instead are active or inactive until you toggle them. And they need to match exactly as well. Whoever thought that's a good design should stop doing so immediately.