Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotkeys do not work when num lock is active #711

Closed
tp971 opened this issue Aug 14, 2023 · 3 comments · Fixed by #762
Closed

Hotkeys do not work when num lock is active #711

tp971 opened this issue Aug 14, 2023 · 3 comments · Fixed by #762
Labels
bug There is a bug. hotkey This is about the hotkey implementation. priority: high This is a high priority issue.

Comments

@tp971
Copy link

tp971 commented Aug 14, 2023

On my system, hotkeys do not work at all when num lock is active. I used the desktop prototype (https://github.com/LiveSplit/livesplit-core). Here is some maybe relevant information:

OS: Debian 12.1 "Bookworm"
DE: Xfce 4.18
rustc: 1.71.1

@CryZe
Copy link
Collaborator

CryZe commented Jan 21, 2024

Alright, with @Pheenoh helping me debug this issue we figured out that the way we register the modifiers (and honestly the only way X11 seems to directly support this) means that no other modifier combination is valid for the hotkey. And unfortunately having the numlock on counts as a modifier. I'll look into ways to fix this.

@CryZe CryZe added bug There is a bug. priority: high This is a high priority issue. hotkey This is about the hotkey implementation. labels Jan 21, 2024
@TheTedder
Copy link
Contributor

You could have an option to always register two hotkeys—one with and without numlock—and then just coalesce them.

@CryZe
Copy link
Collaborator

CryZe commented Jan 21, 2024

Yeah the solution is probably to register every combination that we are not interested in. It just combinatoricly "explodes" because of num lock, scroll lock, caps lock and co.

@CryZe CryZe linked a pull request Jan 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug There is a bug. hotkey This is about the hotkey implementation. priority: high This is a high priority issue.
Projects
Development

Successfully merging a pull request may close this issue.

3 participants