New Low Order MRI Methods #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drreynolds
requested changes
Mar 19, 2024
Co-authored-by: Daniel R. Reynolds <[email protected]>
… feature/low-order-mri
drreynolds
approved these changes
Mar 28, 2024
drreynolds
requested changes
Mar 28, 2024
gardner48
requested changes
Mar 28, 2024
drreynolds
previously approved these changes
Apr 11, 2024
Co-authored-by: Daniel R. Reynolds <[email protected]>
drreynolds
previously approved these changes
Apr 11, 2024
|
Should be ready to merge now pending the jenkins test and any final reviews |
drreynolds
previously approved these changes
May 8, 2024
gardner48
requested changes
May 11, 2024
gardner48
pushed a commit
to sundials-codes/answers
that referenced
this pull request
May 11, 2024
gardner48
approved these changes
May 12, 2024
gardner48
added a commit
that referenced
this pull request
Jun 20, 2024
- Adds new 1st-3rd order MRI methods. Most are from the literature, but the rest are trivial to derive, e.g., Euler-based schemes. - Adds some of the base ERK and IRK method tables too. Note that some cannot be equipped with reasonable embeddings. - Fixes an MRI reallocation bug when switching coupling coefficients to one with more stages - Fixes a workspace size bug for MRIStep - Makes `MRIStepSetOrder` consistent with `ARKStepSetOrder` and `ERKStepSetOrder` so that a negative value sets the default order and a positive value out of range prints an error (when method initialization occurs not when `SetOrder` is called). --------- Co-authored-by: Daniel R. Reynolds <[email protected]> Co-authored-by: David Gardner <[email protected]>
This was referenced Sep 4, 2024
gardner48
pushed a commit
that referenced
this pull request
Sep 4, 2024
Update this documentation for `MRIStepSetOrder` from #439 where low order methods were added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MRIStepSetOrderconsistent withARKStepSetOrderandERKStepSetOrderso that a negative value sets the default order and a positive value out of range prints an error (when method initialization occurs not whenSetOrderis called).Before I update the docs, stability plots, changelog, etc, I want to make sure everyone's ok with these new methods.