Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tags for cmm setup #37

Closed
wants to merge 2 commits into from
Closed

Add tags for cmm setup #37

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb4170b
Update CookedFrameSource.h
ebelchio12 Sep 6, 2023
eacddeb
Update CookedFrameSource.h
ebelchio12 Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions larwirecell/Components/CookedFrameSource.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

#include "WireCellIface/IConfigurable.h"
#include "WireCellIface/IFrameSource.h"
#include "WireCellUtil/Logging.h"
#include "larwirecell/Interfaces/IArtEventVisitor.h"

#include "canvas/Utilities/InputTag.h"
Expand Down Expand Up @@ -42,6 +43,16 @@ namespace wcls {
double m_tick;
int m_nticks;
std::vector<std::string> m_frame_tags;
art::InputTag m_wiener_inputTag;
art::InputTag m_gauss_inputTag;
std::vector<art::InputTag> m_badmasks_inputTag;
art::InputTag m_threshold_inputTag;
bool m_cmm_setup{false}; // true means use cmm setup
std::string m_wiener_tag{"wiener"};
std::string m_gauss_tag{"gauss"};
Comment on lines +46 to +52
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all too specific and must be made more general.

The user may have all different manner of frame and trace tags and there should not be a modal cmm_setup flag. The "cooking" should all be data-driven.

To make tracking these changes easier I suggest closing this PR (no merge) and updating #36.

I'll add more comments in PR #36.

std::string m_cmm_tag; // for now use a single tag for output cmm

WireCell::Log::logptr_t l;
};

}
Expand Down