Add tags for cmm setup #37
Conversation
|
A new Pull Request was created by @ebelchio12 (Ewerton Belchior) for develop. It involves the following packages: larwirecell @LArSoft/level-1-managers, @LArSoft/level-2-managers can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
| art::InputTag m_wiener_inputTag; | ||
| art::InputTag m_gauss_inputTag; | ||
| std::vector<art::InputTag> m_badmasks_inputTag; | ||
| art::InputTag m_threshold_inputTag; | ||
| bool m_cmm_setup{false}; // true means use cmm setup | ||
| std::string m_wiener_tag{"wiener"}; | ||
| std::string m_gauss_tag{"gauss"}; |
There was a problem hiding this comment.
This is all too specific and must be made more general.
The user may have all different manner of frame and trace tags and there should not be a modal cmm_setup flag. The "cooking" should all be data-driven.
To make tracking these changes easier I suggest closing this PR (no merge) and updating #36.
I'll add more comments in PR #36.
|
@ebelchio12, can we close this PR per @brettviren's suggestion above? |
yes, I'll update PR #36 |
No description provided.