Dataclasses refactor and add new to_dict function #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azgabur
force-pushed
the
dataclasses_refactor
branch
5 times, most recently
from
8bb95a6
to
235667d
Compare
averevki
reviewed
Jul 26, 2023
testsuite/tests/kuadrant/authorino/caching/metadata/test_caching.py
Outdated
Show resolved
Hide resolved
averevki
reviewed
Jul 26, 2023
mganisin
reviewed
Jul 27, 2023
azgabur
force-pushed
the
dataclasses_refactor
branch
4 times, most recently
from
9d6ddab
to
26b0e02
Compare
pehala
previously approved these changes
Jul 31, 2023
averevki
reviewed
Jul 31, 2023
azgabur
force-pushed
the
dataclasses_refactor
branch
from
26b0e02
to
9b85682
Compare
pehala
approved these changes
Aug 1, 2023
mganisin
approved these changes
Aug 1, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
dataclasses.asdict()and directobject.to_dict()method calls in favor of newto_dict()function