Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for extended_properties feature #212

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Add tests for extended_properties feature #212

merged 2 commits into from
Aug 28, 2023

Conversation

azgabur
Copy link
Contributor

@azgabur azgabur commented May 30, 2023 •
edited
Loading

  • extended_properties functionality implementation (contains fix of Value class)
  • Test cases:
    • Token normalization
    • Other extended_properties tests
    • Overwrite tests

Contains also:

Closes #108

@azgabur azgabur force-pushed the extended_properties branch 2 times, most recently from b9d5ddb to 67f698b Compare June 1, 2023 17:55
@azgabur
Copy link
Contributor Author

azgabur commented Jun 1, 2023

^Rebase, black formatting, finish Token normalization test

@azgabur azgabur mentioned this pull request Jun 2, 2023
Closed
@azgabur azgabur force-pushed the extended_properties branch 3 times, most recently from 81d19f7 to b678ce6 Compare June 12, 2023 11:09
@azgabur
Copy link
Contributor Author

azgabur commented Jul 11, 2023

Rebase, add new overwrite tests

averevki
averevki reviewed Jul 12, 2023
View reviewed changes
testsuite/openshift/objects/auth_config/sections.py Outdated Show resolved Hide resolved
testsuite/objects/__init__.py Outdated Show resolved Hide resolved
@azgabur
Copy link
Contributor Author

azgabur commented Jul 12, 2023

Comments/Documentation still needs to be rewritten.

@azgabur
Copy link
Contributor Author

azgabur commented Jul 24, 2023

Re-did basic extended properties test. Rebased and squashed commits. All tasks complete. Ready for review.

@azgabur azgabur marked this pull request as ready for review July 24, 2023 19:37
@azgabur azgabur force-pushed the extended_properties branch 2 times, most recently from 41dcda3 to 9c85c4f Compare August 2, 2023 14:32
@azgabur azgabur mentioned this pull request Aug 2, 2023
Merged
@mganisin
Copy link

mganisin commented Aug 3, 2023

Removal of Union and use of kw_only deserves special acknowledgement :-)

@azgabur azgabur force-pushed the extended_properties branch 2 times, most recently from bd2cdfb to e0dcde1 Compare August 7, 2023 11:54
@azgabur azgabur force-pushed the extended_properties branch 2 times, most recently from 65c3e95 to f7c574b Compare August 7, 2023 12:08
@azgabur azgabur force-pushed the extended_properties branch 4 times, most recently from bd1423c to 360550e Compare August 9, 2023 11:40
pehala
pehala previously approved these changes Aug 16, 2023
View reviewed changes
@azgabur
Copy link
Contributor Author

azgabur commented Aug 25, 2023

^Fix merge conflict & rebase

@pehala pehala merged commit bc087b2 into Kuadrant:main Aug 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mganisin mganisin mganisin left review comments

@averevki averevki averevki approved these changes

@pehala pehala pehala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add test for extraProperties
4 participants
@azgabur @mganisin @pehala @averevki